Redmine

I'm not sure if uwsgi is officially supported. The best way would be if they implement the method in their adapter.
https://github.com/unbit/uwsgi/blob/master/plugins/rack/rack_plugin.c

we could use a fallback, but it'll load the whole file into a memory again on adapters that don't support the feature. A compromise?

diff --git a/app/controllers/attachments_controller.rb b/app/controllers/attachments_controller.rb
index 8e28194a3..f62c35976 100644
--- a/app/controllers/attachments_controller.rb
+++ b/app/controllers/attachments_controller.rb
@@ -105,7 +105,7 @@ class AttachmentsController < ApplicationController
       return
     end

-    @attachment = Attachment.new(:file => request.body)
+    @attachment = Attachment.new(:file => request.body.respond_to?(:size) ? request.body : request.raw_post)
     @attachment.author = User.current
     @attachment.filename = params[:filename].presence || Redmine::Utils.random_hex(16)
     @attachment.content_type = params[:content_type].presence

Go MAEDA what do you think?

uwsgi is certainly an unusual application server... However, as restoring basic support for it should be rather simple, and it did work before, I'm in favor of providing a fallback as you proposed.

I'd just recommend to extract the check to a separate method with some comments describing why we are doing this. This could look like:

class AttachmentController
  #...

  private

  # Get an IO-like object for the request body which is usable to create a new
  # attachment. We try to avoid having to read the whole body into memory.
  def raw_request_body
    if request.body.respond_to?(:size)
      request.body
    else
      request.raw_body
    end
  end
end

thanks, I agree, but the target version should be 4.1.5 because the original change went to 4.1.4

and there's also a typo in the new patch, it should be request.raw_post instead of request.raw_body