Defect #36258
closed
Support revision without any message in Mercurial repositories
Added by salman mp about 3 years ago. Updated over 2 years ago.
0%
Description
In sophesticated position a repository may contain revision without message.
Files
| empty_message.diff (809 Bytes) empty_message.diff | salman mp, 2021-11-29 16:32 | ||
| 0001-Update-test-fixtures-repositories-mercurial_reposito.patch (31.5 KB) 0001-Update-test-fixtures-repositories-mercurial_reposito.patch | Yuichi HARADA, 2021-12-24 06:38 | ||
| 0002-Update-tests-and-add-a-test-for-empty-commit-message.patch (4.67 KB) 0002-Update-tests-and-add-a-test-for-empty-commit-message.patch | Yuichi HARADA, 2021-12-24 06:38 |
Updated by Go MAEDA about 3 years ago
I'm not familiar with Mercurial, so I don't understand the improvements the patch brings. Could you explain the benefits?
Updated by salman mp about 3 years ago
Mercurial is very similar to git. I added another source to my repository, and when did pull from that source, unbelievably there is a revision without any commit message. When I wanted to fetch changesets, there was an exception (line that patched).
Updated by Go MAEDA about 3 years ago
Thank you, I understand the situation.
Can you please paste the error message in production.log？
Updated by salman mp about 3 years ago
Go MAEDA wrote:
Thank you, I understand the situation.
Can you please paste the error message in production.log？
Started GET "/projects/test/repository" for 31.57.0.155 at 2021-12-22 11:18:02 +0330
App 2260378 output: Processing by RepositoriesController#show as HTML
App 2260378 output: Parameters: {"id"=>"test"}
App 2260378 output: Current user: user (id=1)
App 2260378 output: Completed 500 Internal Server Error in 706ms (ActiveRecord: 6.4ms)
App 2260378 output:
App 2260378 output: TypeError (no implicit conversion of nil into String):
App 2260378 output:
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `unescape'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:233:in `block in each_revision'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each'
App 2260378 output: lib/redmine/scm/adapters/mercurial_adapter.rb:203:in `each_revision'
App 2260378 output: app/models/repository/mercurial.rb:194:in `block in fetch_changesets'
App 2260378 output: app/models/repository/mercurial.rb:193:in `step'
App 2260378 output: app/models/repository/mercurial.rb:193:in `fetch_changesets'
App 2260378 output: app/controllers/repositories_controller.rb:87:in `show'
App 2260378 output: lib/redmine/sudo_mode.rb:61:in `sudo_mode'
Updated by Yuichi HARADA about 3 years ago
- File 0001-Update-test-fixtures-repositories-mercurial_reposito.patch 0001-Update-test-fixtures-repositories-mercurial_reposito.patch added
- File 0002-Update-tests-and-add-a-test-for-empty-commit-message.patch 0002-Update-tests-and-add-a-test-for-empty-commit-message.patch added
I have confirmed this issue. Applying the patch(empty_message.diff) solved it. thank you.
I created MercurialAdapterTest#test_empty_message because there was no test.
Updated by Go MAEDA about 3 years ago
- Target version set to Candidate for next minor release
Updated by Go MAEDA over 2 years ago
- Target version changed from Candidate for next minor release to 5.0.3
Setting the target version to 5.0.3.
Updated by Future Link Corporation pkgsrc team over 2 years ago
Any way we can get this merged ASAP? It's the only issue blocking 5.0.3. We're unable to upgrade our Redmine ATM, because pkgsrc has Rails 6.1.6.1 which is supported only by the next minor release.
Updated by Go MAEDA over 2 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the patches. Thank you for your contribution.
Updated by Go MAEDA over 2 years ago
- Tracker changed from Patch to Defect
- Subject changed from Support revision without any message to Support revision without any message in Mercurial repositories
- Resolution set to Fixed