Project

General

Profile

Actions

Defect #36273

closed

Modifying the source code of a plugin does not reload it after r21295

Added by Hirokazu Onozato almost 3 years ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Rails support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

It seems that modifying the source code of a plugin in development mode does not reload it anymore.

For example, if you change the following file

  • plugins/redmine_issue_assign_notice/lib/redmine_issue_assign_notice/notice_client.rb

In Redmine trunk r21295 does not reload.
In 4.2.2, it was reloaded.

If i change the source code of Redmine itself, it will be reloaded in trunk r21295 as well.

  • app/models/issue.rb

Has Zeitwerk support removed the Redmine plugin folder from monitoring?


Files


Related issues

Related to Redmine - Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloadingClosedGo MAEDA

Actions
Related to Redmine - Defect #36218: Plugin assets are not copied correctly in trunk r21289ClosedMarius BÄ‚LTEANU

Actions
Has duplicate Redmine - Defect #38021: Development mode, class-reloader is not work.Closed

Actions
Actions #1

Updated by Takashi Kato almost 2 years ago

After some research, I've found out that the directory settings monitored by Zeitwerk and monitored by the Reloader must be done respectively.
(In the code of Redmine itself, these settings done automatically by Rails.)

The attached patch will fix the problem(can be applied to r21991).

Actions #2

Updated by Go MAEDA almost 2 years ago

  • Related to Feature #29914: Migrate to Rails 6.1 with Zeitwerk autoloading added
Actions #3

Updated by Go MAEDA almost 2 years ago

  • Related to Defect #36218: Plugin assets are not copied correctly in trunk r21289 added
Actions #4

Updated by Go MAEDA almost 2 years ago

  • Category set to Rails support
  • Status changed from New to Confirmed
  • Target version set to Candidate for next minor release
Actions #5

Updated by Go MAEDA almost 2 years ago

  • Subject changed from Modifying the source code of the plugin does not reload it in trunk 21295 to Modifying the source code of a plugin does not reload it after r21295
  • Target version changed from Candidate for next minor release to 5.0.5
  • Affected version set to 5.0.0

Setting the target version to 5.0.5.

Actions #6

Updated by Go MAEDA almost 2 years ago

  • Status changed from Confirmed to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the fix. Thank you.

Actions #7

Updated by Go MAEDA almost 2 years ago

  • Has duplicate Defect #38021: Development mode, class-reloader is not work. added
Actions #8

Updated by Go MAEDA almost 2 years ago

  • Status changed from Resolved to Closed
Actions #9

Updated by Hirokazu Onozato over 1 year ago

Thanks!

Actions

Also available in: Atom PDF