Redmine

Thank you for posting the patch that fixes the issue that has not been fixed for years.

However, I found an issue with Safari that all preceding white spaces of a line are stripped.

before:

after:

Thanks for testing, but I am afraid I need more details about the issue, because it works fine on macOS 12.2 with the latest Safari for me.

• What Safari version do you have?
• Could you post the source of the file?
• Could you post HTML source of page? Could do both the whole part of just the important part. E.g. I have
  

  <div>    <span class="k">union</span> <span class="n">ldshape</span> <span class="n">u</span> <span class="o">=</span> <span class="p">{</span><span class="n">x</span><span class="p">};</span>
  </div>
  

• Could you also post computed CSS for the div element? I attached mine on the screenshot to get an idea what I need

Maeda-san, could you clarify this?

I found that the "issue" I reported in #36580#note-1 was due to browser cache. Super reload resolved the issue. I am very sorry for bothering you.

Setting the target version to 5.0.0.

Updated the patch to include fixes for existing tests.

Go MAEDA wrote:

Updated the patch to include fixes for existing tests.

The test in test/functional/repositories_cvs_controller_test.rb failed, so I fixed the test and added it to 36580-v2.patch.

Failure:
RepositoriesCvsControllerTest#test_annotate [test/functional/repositories_cvs_controller_test.rb:285]:
<21> expected but was
<>..
Expected 0 to be >= 1.

rails test test/functional/repositories_cvs_controller_test.rb:268

diff --git a/test/functional/repositories_cvs_controller_test.rb b/test/functional/repositories_cvs_controller_test.rb
index 09db1611a8..fdd8e986d1 100644
--- a/test/functional/repositories_cvs_controller_test.rb
+++ b/test/functional/repositories_cvs_controller_test.rb
@@ -283,13 +283,13 @@ class RepositoriesCvsControllerTest < Redmine::RepositoryControllerTest

       # 1.1 line
       assert_select 'tr' do
-        assert_select 'th.line-num', :text => '21'
+        assert_select 'th.line-num a[data-txt=?]', '21'
         assert_select 'td.revision', :text => /1.1/
         assert_select 'td.author', :text => /LANG/
       end
       # 1.2 line
       assert_select 'tr' do
-        assert_select 'th.line-num', :text => '32'
+        assert_select 'th.line-num a[data-txt=?]', '32'
         assert_select 'td.revision', :text => /1.2/
         assert_select 'td.author', :text => /LANG/
       end

Committed the patch. Thank you.