Redmine

Just a thought:

The following code in Issue#workflow_rule_by_attribute (source:/trunk/app/models/issue.rb@21799#L680) exists:

    user_real = user || User.current
    roles = user_real.admin ? Role.all.to_a : user_real.roles_for_project(project)
    roles = roles.select(&:consider_workflow?)

The following code addition is proposed in this patch:

    roles = user.admin ? Role.all.to_a : user.roles_for_project(project)
    roles = roles.select(&:consider_workflow?)

Wouldn't it be better to extract this code into a new (helper) method given the similarity?

Mischa The Evil wrote:

Wouldn't it be better to extract this code into a new (helper) method given the similarity?

What do you think about extracting the code as follows?

diff --git a/app/models/issue.rb b/app/models/issue.rb
index 84907a475..a5bd372d5 100644
--- a/app/models/issue.rb
+++ b/app/models/issue.rb
@@ -2053,4 +2053,9 @@ class Issue < ActiveRecord::Base
       Project
     end
   end
+
+  def roles_for_workflow(user = User.current)
+    roles = user.admin ? Role.all.to_a : user.roles_for_project(project)
+    roles.select(&:consider_workflow?)
+  end
 end