Project

General

Profile

Actions

Patch #37938

closed

Unused permission "Mention user"

Patch #37938: Unused permission "Mention user"

Added by Go MAEDA about 4 years ago. Updated almost 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:

Description

In Permissions and Roles, you can find "Mention users" permission. However, this permission is not used at all. You can mention a user even if you don't have "Mention users" permission.

I think this unused "Mention users" permission should be removed.

diff --git a/lib/redmine/preparation.rb b/lib/redmine/preparation.rb
index b4e37fd50..9181710ba 100644
--- a/lib/redmine/preparation.rb
+++ b/lib/redmine/preparation.rb
@@ -73,7 +73,6 @@ module Redmine
           map.permission :set_notes_private, {}, :require => :member
           map.permission :delete_issues, {:issues => :destroy}, :require => :member
           map.permission :change_issue_author, {:issues => [:edit, :update]}
-          map.permission :mention_users, {}
           # Watchers
           map.permission :view_issue_watchers, {}, :read => true
           map.permission :add_issue_watchers, {:watchers => [:new, :create, :append, :autocomplete_for_user, :autocomplete_for_mention]}

Related issues 2 (0 open — 2 closed)

Related to Redmine - Feature #13919: Mention user on issues and wiki pages using @user with autocompleteClosedMarius BĂLTEANUActions
Related to Redmine - Patch #37974: Database migration to remove unused "mention_users" permissionClosedGo MAEDAActions

Updated by Holger Just about 4 years ago Actions #1

  • Related to Feature #13919: Mention user on issues and wiki pages using @user with autocomplete added

Updated by Holger Just about 4 years ago Actions #2

This appears to be a remaining artifact of the discussion around #13919#note-75. The permission indeed appears to be unused now and can be removed.

However, I'm wondering if we need to actually remove it from any roles which might have this permission defined now? Or if we could just not care?

Updated by Marius BĂLTEANU almost 4 years ago Actions #3

  • Assignee set to Marius BĂLTEANU
  • Target version set to 5.0.4

Updated by Marius BĂLTEANU almost 4 years ago Actions #4

  • Status changed from New to Resolved

I've removed the permission and I've added an issue (#37974) to 5.1.0 to cleanup the permission from the database.

Updated by Marius BĂLTEANU almost 4 years ago Actions #5

  • Related to Patch #37974: Database migration to remove unused "mention_users" permission added

Updated by Marius BĂLTEANU almost 4 years ago Actions #6

  • Status changed from Resolved to Closed
Actions

Also available in: PDF Atom