Project

General

Profile

Actions

Patch #37938

closed

Unused permission "Mention user"

Added by Go MAEDA over 1 year ago. Updated over 1 year ago.

Status:
Closed
Priority:
Normal
Category:
Code cleanup/refactoring
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

In Permissions and Roles, you can find "Mention users" permission. However, this permission is not used at all. You can mention a user even if you don't have "Mention users" permission.

I think this unused "Mention users" permission should be removed.

diff --git a/lib/redmine/preparation.rb b/lib/redmine/preparation.rb
index b4e37fd50..9181710ba 100644
--- a/lib/redmine/preparation.rb
+++ b/lib/redmine/preparation.rb
@@ -73,7 +73,6 @@ module Redmine
           map.permission :set_notes_private, {}, :require => :member
           map.permission :delete_issues, {:issues => :destroy}, :require => :member
           map.permission :change_issue_author, {:issues => [:edit, :update]}
-          map.permission :mention_users, {}
           # Watchers
           map.permission :view_issue_watchers, {}, :read => true
           map.permission :add_issue_watchers, {:watchers => [:new, :create, :append, :autocomplete_for_user, :autocomplete_for_mention]}

Related issues

Related to Redmine - Feature #13919: Mention user on issues and wiki pages using @user with autocompleteClosedMarius BĂLTEANU

Actions
Related to Redmine - Patch #37974: Database migration to remove unused "mention_users" permissionClosedGo MAEDA

Actions
Actions

Also available in: Atom PDF