Defect #38210
closed
Incorrect DB migration version
0%
Description
r22038 added the 20221214173537_add_select_project_publicity_permission.rb migration file. However, it is versioned as a Rails/AR 5.2 migration while at the time of the commit the trunk was already on Rails 6.1.
I'm not sure if this was done for a specific purpose nor if changing this retroactively will cause other issues. But I thought it would at least be good to report it here as such.
Related issues
Updated by Go MAEDA 8 months ago
Thank you for pointing this out. This was my mistake and I should have changed the version to 6.1 before committing.
I think it is safe to change source:trunk/db/migrate/20221214173537_add_select_project_publicity_permission.rb to update the version from 5.2 to 6.1 because the code in the migration is a simple Rails code and the behavior does not change depending on the version of Migration.
Updated by Holger Just 8 months ago
- Related to Feature #38048: Introduce permission to set a project public added
Updated by Holger Just 8 months ago
Yeah, just updating this will probably be fine as there is no DDL involved in the migration (and even then, it would likely be okay).