Project

General

Profile

Actions
Copy link

Defect #38509

closed

Untranslated string "OK" in the repository browser

Added by Go MAEDA over 1 year ago. Updated 12 months ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
I18n
Target version:
5.1.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

An untranslated string "OK" is used in the repository browser. The attached patch changes the hard-coded "OK" to "View" (button_view).

The issue was pointed out in #31698 by Kam Nazir.

Files

Download all files
clipboard-202305031606-xgclf.png (167 KB) clipboard-202305031606-xgclf.png Go MAEDA, 2023-05-03 09:06
untranslated-string-OK.patch (934 Bytes) untranslated-string-OK.patch Go MAEDA, 2023-05-03 09:08

Related issues

Related to Redmine - Defect #31698: Some unlocalize stringNew

Actions
Related to Redmine - Defect #39778: Untranslated string "OK" in the repository browserClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Go MAEDA over 1 year ago

Actions
Copy link
 #2

Updated by Go MAEDA over 1 year ago

  • Target version set to 5.1.0

Setting the target version to 5.1.0.

Actions
Copy link
 #3

Updated by Go MAEDA over 1 year ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch.

Actions
Copy link
 #4

Updated by salman mp 12 months ago

One another 'OK' missed in diff page.

source:/trunk/app/views/repositories/diff.html.erb#L26

Actions
Copy link
 #5

Updated by Mischa The Evil 12 months ago

salman mp wrote in #note-4:

One another 'OK' missed in diff page.

source:/trunk/app/views/repositories/diff.html.erb#L26

Thanks for the report. I've opened #39778 for this since 5.1.0 has already been released.

Actions
Copy link
 #6

Updated by Mischa The Evil 12 months ago

  • Related to Defect #39778: Untranslated string "OK" in the repository browser added
Actions
Copy link

Also available in: Atom PDF