Project

General

Profile

Actions

Feature #43205

open

Update to Rails 8

Added by Marius BĂLTEANU 17 days ago. Updated 1 day ago.

Status:
New
Priority:
Normal
Category:
Rails support
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Related issues

Related to Redmine - Patch #43266: Update activerecord-sqlserver-adapter to 8.0ClosedMarius BĂLTEANU

Actions
Related to Redmine - Defect #43268: Labels not displayed for form.text_area fields in Redmine with Rails 8ClosedMarius BĂLTEANU

Actions
Blocked by Redmine - Defect #43230: [Rails 8] ArgumentError: wrong number of arguments (given 0, expected 1) in ApplicationController#find_model_objectClosedMarius BĂLTEANU

Actions
Blocked by Redmine - Defect #43231: DEPRECATION WARNING: `to_time` will always preserve the receiver timezone rather than system local time in Rails 8.1New

Actions
Actions #1

Updated by Marius BĂLTEANU 9 days ago

  • Related to Defect #43230: [Rails 8] ArgumentError: wrong number of arguments (given 0, expected 1) in ApplicationController#find_model_object added
Actions #2

Updated by Marius BĂLTEANU 9 days ago

  • Related to deleted (Defect #43230: [Rails 8] ArgumentError: wrong number of arguments (given 0, expected 1) in ApplicationController#find_model_object)
Actions #3

Updated by Marius BĂLTEANU 9 days ago

  • Blocked by Defect #43230: [Rails 8] ArgumentError: wrong number of arguments (given 0, expected 1) in ApplicationController#find_model_object added
Actions #4

Updated by Marius BĂLTEANU 9 days ago

  • Blocked by Defect #43231: DEPRECATION WARNING: `to_time` will always preserve the receiver timezone rather than system local time in Rails 8.1 added
Actions #5

Updated by Marius BĂLTEANU 2 days ago

Rails updated to 8.0.2.

Actions #6

Updated by Marius BĂLTEANU 2 days ago

  • Category set to Rails support
  • Assignee set to Marius BĂLTEANU
  • Resolution set to Fixed
Actions #7

Updated by Go MAEDA 2 days ago

  • Related to Patch #43266: Update activerecord-sqlserver-adapter to 8.0 added
Actions #8

Updated by Katsuya HIDAKA 1 day ago

System tests have been failing on CI since changeset r24016.
https://github.com/redmine/redmine/actions/runs/18080047607/job/51442007411#step:5:48

Error:
InlineAutocompleteSystemTest#test_inline_autocomplete_on_news_description_should_show_autocomplete:
Capybara::ElementNotFound: Unable to find field "Description" that is not disabled
    test/system/inline_autocomplete_test.rb:128:in 'InlineAutocompleteSystemTest#test_inline_autocomplete_on_news_description_should_show_autocomplete'

bin/rails test test/system/inline_autocomplete_test.rb:120

...............................................................[Screenshot Image]: /home/runner/work/redmine/redmine/tmp/screenshots/failures_test_application_creation_and_authorization.png
E

Error:
OauthProviderSystemTest#test_application_creation_and_authorization:
Capybara::ElementNotFound: Unable to find field "Redirect URI" that is not disabled
    test/system/oauth_provider_test.rb:25:in 'block (2 levels) in <class:OauthProviderSystemTest>'
    test/test_helper.rb:109:in 'ActiveSupport::TestCase#with_settings'
    test/system/oauth_provider_test.rb:15:in 'block in <class:OauthProviderSystemTest>'

bin/rails test test/system/oauth_provider_test.rb:9

From the screenshots available through the system-test-screenshots artifact on the job summary page , it seems that some form field labels are missing.

Note: System tests have been marked with continue-on-error: true since they were introduced, because they were a bit unstable at that time. As a result, even if system tests fail, the job does not fail, but the errors can be seen on the job summary page. That said, system test runs have become almost stable, so I will submit a patch to disable continue-on-error .

Actions #9

Updated by Mizuki ISHIKAWA 1 day ago

Katsuya HIDAKA wrote in #note-8:

System tests have been failing on CI since changeset r24016.
https://github.com/redmine/redmine/actions/runs/18080047607/job/51442007411#step:5:48

I created a separate issue(#43268) for the problem in #note-8 because it was a bit complicated.

Actions #10

Updated by Marius BĂLTEANU 1 day ago

  • Related to Defect #43268: Labels not displayed for form.text_area fields in Redmine with Rails 8 added
Actions

Also available in: Atom PDF