Project

General

Profile

Actions

Patch #43214

closed

Optimize Project.allowed_to_condition by replacing `projects.status <> ...` with `projects.status IN (...)`

Added by Go MAEDA 2 days ago. Updated 2 days ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Performance
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The attached patch replaces the condition projects.status <> ... with the equivalent projects.status IN (...) in the Project.allowed_to_condition method.

This change makes the SQL clearer and may improve performance, since IN (...) is generally more optimizer-friendly than a combination of <> conditions. A performance benefit of this approach was also observed during the investigation of #40728 (see #40728#note-15 and #40728#note-16).


Files


Related issues

Related to Redmine - Feature #36691: Background job and dedicated status for project deletionClosedMarius BĂLTEANU

Actions
Actions #1

Updated by Go MAEDA 2 days ago

  • Subject changed from Optimize Project.allowed_to_condition by `replacing projects.status <> ...` with `projects.status IN (...)` to Optimize Project.allowed_to_condition by replacing `projects.status <> ...` with `projects.status IN (...)`
Actions #2

Updated by Holger Just 2 days ago

Looks good to me, thanks!

Actions #3

Updated by Go MAEDA 2 days ago

  • Description updated (diff)
  • Target version set to 6.1.0
Actions #4

Updated by Go MAEDA 2 days ago

  • Related to Feature #36691: Background job and dedicated status for project deletion added
Actions #5

Updated by Go MAEDA 2 days ago

  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Thank you for reviwing the change. I have committed the change in r23979.

Actions

Also available in: Atom PDF