Defect #6324
open
requires_redmine_plugin should defer loading plugins if not all dependencies are met
Added by Tim Felgentreff about 14 years ago. Updated over 1 year ago.
0%
Description
requires_redmine_plugin is a nice facility to track inter-plugin dependencies, however, it is useless if I do not want (or cannot) rename plugins I depend on.
I propose that plugins are deferred and loaded at a later time, if possible.
See attached patch for a proposed solution.
Files
| 0001-implement-redmine-plugin-loader.patch (3.92 KB) 0001-implement-redmine-plugin-loader.patch | Tim Felgentreff, 2010-09-07 22:01 | ||
| 0001-implement-redmine-plugin-loader.patch (3.88 KB) 0001-implement-redmine-plugin-loader.patch | Tim Felgentreff, 2010-09-08 01:14 | ||
| 0001-implement-redmine-plugin-loader.patch (3.88 KB) 0001-implement-redmine-plugin-loader.patch | Tim Felgentreff, 2010-09-08 11:29 | ||
| 0001-Add-a-Redmine-plugin-locator-to-be-able-to-query-the.patch (4.77 KB) 0001-Add-a-Redmine-plugin-locator-to-be-able-to-query-the.patch | Tim Felgentreff, 2010-09-08 11:54 | ||
| 6324_defer_plugin_requirements_evaluation.patch (6.97 KB) 6324_defer_plugin_requirements_evaluation.patch | Jean-Baptiste Barth, 2014-08-14 13:06 | ||
| init.rb (1.39 KB) init.rb | 000_pluginloader | Michael Krupp, 2016-02-03 18:35 | |
| init.rb (160 Bytes) init.rb | zzz_pluginloader | Michael Krupp, 2016-02-03 18:35 | |
| 0001-Defer-plugin-requirements-evaluation.patch (6.74 KB) 0001-Defer-plugin-requirements-evaluation.patch | Takashi Kato, 2023-04-25 00:31 |
Related issues
Updated by Tim Felgentreff about 14 years ago
- File 0001-implement-redmine-plugin-loader.patch 0001-implement-redmine-plugin-loader.patch added
- Assignee set to Eric Davis
Remove debugger code
Updated by Tim Felgentreff about 14 years ago
Also, for some reason, the patch I posted doesn't apply with git am. So if you use that, here's one that does. (No code changes)
Updated by Tim Felgentreff about 14 years ago
- File 0001-Add-a-Redmine-plugin-locator-to-be-able-to-query-the.patch 0001-Add-a-Redmine-plugin-locator-to-be-able-to-query-the.patch added
Just found a bug with my patch where the asset directory wasn't set properly. Changed it to not replace the rails plugin locator, but use Redmine's in addition to the default one. This probably nicer, anyway, in case people want to add locators themselves. In the new implementation, the Redmine plugin locator doesn't load anything, but is only for querying the Rails plugin search path.
Updated by Eric Davis about 14 years ago
- Target version set to Unplanned backlogs
Updated by Eric Davis almost 14 years ago
- Assignee deleted (
Eric Davis)
I am stepping down from working on Redmine. If someone else is interesting in working on this issue, feel free to reassign it to them.
Eric Davis
Updated by Toshi MARUYAMA about 13 years ago
Updated by Massimo Rossello almost 11 years ago
For anyone not willing to patch the core, not requiring an end user to manage his environment.rb, I found the following workaround to be prepended on the dependent plugin's init.rb:
dep = File.join(Rails.root,'plugins','<plugin name>')
ActiveSupport::Dependencies.autoload_paths += [File.join(dep, 'lib')]
require_dependency File.join(dep, 'init')
Updated by Jean-Baptiste Barth over 10 years ago
- File 6324_defer_plugin_requirements_evaluation.patch 6324_defer_plugin_requirements_evaluation.patch added
- Category set to Plugin API
- Assignee set to Jean-Baptiste Barth
- Target version changed from Unplanned backlogs to Candidate for next major release
Sorry to be late at the party, but I'd like this issue solved as it bothers me from time to time.
I find Tim's proposed implementation a bit complex (and the one integrated in chiliproject is even more complex) where all we'd have to do is defer the requirement check until the end of Redmine::Plugin.load method. Sure it's not as evolved but I think it should be enough.
Here's a proposed patch, I'd like to hear some opinions before committing it, and if you see obvious advantages to Tim's/Chiliproject's approach, let me know.
Updated by Vincent Robert about 10 years ago
It seems to be the simplest fix, straight-forward and easy to understand.
The other implementations, much more complex, are error-prone processes in my opinion.
Updated by Michael Krupp almost 9 years ago
As this issue seems to make no real progress in any direction, I implemented Jean-Baptiste's Patch as a plugin.
Just save them as plugins/000_pluginloader/init.rb and plugins/zzz_pluginloader/init.rb. done.
Updated by Mischa The Evil over 8 years ago
- Has duplicate Feature #23131: Plugin load order defined by inter-plugin dependencies added
Updated by Michael Krupp about 8 years ago
Just a quick update: I merged the two plugin-files into one standalone plugin by abusing the mirror_assets method call in the redmine initializer. This plugin does not change the load order of plugins - it only defers the dependency check, as suggested in #6324-8
Updated by Massimo Rossello about 6 years ago
Following approach is simple and does work. Applied in my_plugin's init.rb to check a dependency dependency_plugin.
The check happens after all plugins have been registered.
Rails.configuration.to_prepare do
Redmine::Plugin.find(:my_plugin).requires_redmine_plugin :dependency_plugin, :version_or_higher => '1.0.0'
end
Updated by Takashi Kato over 1 year ago
- File 0001-Defer-plugin-requirements-evaluation.patch 0001-Defer-plugin-requirements-evaluation.patch added
A patch for version 5.0 or later is here.