Defect #8251: Classic Theme: Missed base line - Redmine

Defect #8251

Classic Theme: Missed base line

Added by Anton Lem over 9 years ago. Updated about 1 month ago.

Status:

Closed

Start date:

2011-04-29

Priority:

Low

Due date:

Assignee:

Go MAEDA

% Done:

Category:

Themes

Target version:

4.0.8

Resolution:

Fixed

Affected version:

1.1.2

Description

Tab Control in Classic Theme is looking like this , without bottom base line.
It seems to me, it designed to look like this

tabs1.gif (5.77 KB) Anton Lem, 2011-04-29 08:24

tabs2.gif (5.82 KB) Anton Lem, 2011-04-29 08:24

tabs2-altered.gif (6.82 KB) Mischa The Evil, 2011-04-29 23:00

ScreenShot-2020-06-10-9.02.59.png (64 KB) Mizuki ISHIKAWA, 2020-06-10 02:03

Associated revisions

Revision 19841
Added by Go MAEDA about 1 month ago

Classic Theme: Missed base line (#8251).

Patch by Mizuki ISHIKAWA.

Revision 19842
Added by Go MAEDA about 1 month ago

Merged r19841 from trunk to 4.1-stable (#8251).

Revision 19843
Added by Go MAEDA about 1 month ago

Merged r19841 from trunk to 4.0-stable (#8251).

History

#1 Updated by Mischa The Evil over 9 years ago

File tabs2-altered.gif added

I think it was designed rather a bit different, looking like this:

What do you think?

#2 Updated by Anton Lem over 9 years ago

You are absolutely right! I attached my image only for example.

#3 Updated by johann sebatian over 9 years ago

Assignee set to johann sebatian

#4 Updated by Mizuki ISHIKAWA about 1 month ago

File ScreenShot-2020-06-10-9.02.59.png added

If you delete the line as below, it will look like the screenshot.

diff --git a/public/themes/classic/stylesheets/application.css b/public/themes/classic/stylesheets/application.css
index 523104dcb..5104626b0 100644
--- a/public/themes/classic/stylesheets/application.css
+++ b/public/themes/classic/stylesheets/application.css
@@ -29,7 +29,6 @@ body{ color:#303030; background:#e8eaec; }
 #main a { font-weight: bold; color: #467aa7;}
 #main a:hover { color: #2a5a8a; text-decoration: underline; }
 #content { background: #fff; }
-#content .tabs ul { bottom:-1px; }

 h2, h3, h4, .wiki h1, .wiki h2, .wiki h3 { border-bottom: 0px; color:#606060; font-family: Trebuchet MS,Georgia,"Times New Roman",serif; }
 h2, .wiki h1 { letter-spacing:-1px; }