Defect #8251
closed
Classic Theme: Missed base line
Added by Anton Lem over 13 years ago. Updated over 4 years ago.
0%
Description
Tab Control in Classic Theme is looking like this 
, without bottom base line.
It seems to me, it designed to look like this 
Files
| tabs1.gif (5.77 KB) tabs1.gif | Anton Lem, 2011-04-29 08:24 | ||
| tabs2.gif (5.82 KB) tabs2.gif | Anton Lem, 2011-04-29 08:24 | ||
| tabs2-altered.gif (6.82 KB) tabs2-altered.gif | Mischa The Evil, 2011-04-29 23:00 | ||
| ScreenShot-2020-06-10-9.02.59.png (64 KB) ScreenShot-2020-06-10-9.02.59.png | Mizuki ISHIKAWA, 2020-06-10 02:03 |
Updated by Mischa The Evil over 13 years ago
- File tabs2-altered.gif tabs2-altered.gif added
I think it was designed rather a bit different, looking like this:
What do you think?
Updated by Anton Lem over 13 years ago
You are absolutely right! I attached my image only for example.
Updated by
Updated by Mizuki ISHIKAWA over 4 years ago
If you delete the line as below, it will look like the screenshot.
diff --git a/public/themes/classic/stylesheets/application.css b/public/themes/classic/stylesheets/application.css
index 523104dcb..5104626b0 100644
--- a/public/themes/classic/stylesheets/application.css
+++ b/public/themes/classic/stylesheets/application.css
@@ -29,7 +29,6 @@ body{ color:#303030; background:#e8eaec; }
#main a { font-weight: bold; color: #467aa7;}
#main a:hover { color: #2a5a8a; text-decoration: underline; }
#content { background: #fff; }
-#content .tabs ul { bottom:-1px; }
h2, h3, h4, .wiki h1, .wiki h2, .wiki h3 { border-bottom: 0px; color:#606060; font-family: Trebuchet MS,Georgia,"Times New Roman",serif; }
h2, .wiki h1 { letter-spacing:-1px; }
Updated by Go MAEDA over 4 years ago
- Status changed from New to Confirmed
- Assignee deleted (
johann sebatian) - Target version set to Candidate for next major release
Updated by Go MAEDA over 4 years ago
- Target version changed from Candidate for next major release to 4.0.8
LGTM. Setting the target version to 4.0.8.
Updated by Mischa The Evil over 4 years ago
Wow, that's a throwback in time...
Go MAEDA wrote:
LGTM.
I agree, but only as long as it does not come with unintended side-effects in other parts of the UI.
Updated by Go MAEDA over 4 years ago
Mischa The Evil wrote:
I agree, but only as long as it does not come with unintended side-effects in other parts of the UI.
I have looked tabs in pages generated from the following templates and didn't find problems.
- app/views/custom_fields/index.html.erb
- app/views/groups/edit.html.erb
- app/views/issues/show.html.erb
- app/views/projects/settings.html.erb
- app/views/repositories/_changeset.html.erb
- app/views/settings/edit.html.erb
- app/views/timelog/_date_range.html.erb
- app/views/users/edit.html.erb
- app/views/workflows/edit.html.erb
- app/views/workflows/permissions.html.erb
Updated by Go MAEDA over 4 years ago
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you.