Feature #16849
closedRender Textile and Markdown files in the repository browser
Added by Arne v.Irmer over 10 years ago. Updated over 3 years ago.
0%
Description
It would be fine to render *.md in Reposotory -> View | Annotate with the redmine Markdown rendering-Engine.
Files
16849.patch (3.08 KB) 16849.patch | Takenori TAKAKI, 2021-05-14 03:50 | ||
16849-subversion_repository.dump.gz (113 KB) 16849-subversion_repository.dump.gz | Takenori TAKAKI, 2021-05-14 04:00 | ||
16849-repository_subversion_test.patch (1.22 KB) 16849-repository_subversion_test.patch | Takenori TAKAKI, 2021-05-14 05:20 | ||
Screenshot_2021-05-25.png (30.8 KB) Screenshot_2021-05-25.png | Go MAEDA, 2021-05-25 10:14 | ||
16849-v2.patch (4.11 KB) 16849-v2.patch | Go MAEDA, 2021-05-27 11:14 |
Related issues
Updated by Go MAEDA over 5 years ago
- Related to Feature #29752: Render Textile and Markdown attachments on the preview page added
Updated by Go MAEDA over 5 years ago
- Subject changed from Add Mark-Downrendering in Reposotory -> View | Annotate to Add Markdown rendering in Reposotory -> View | Annotate
Updated by Erik E over 5 years ago
+1 That would be a great and very useful addition. I hope that #29752 will help this feature request.
Updated by Adrien Crivelli over 3 years ago
+1, I'd love to see this now that #29752 has landed, and with the increasing use of Markdown everywhere.
Updated by Takenori TAKAKI over 3 years ago
- File 16849.patch 16849.patch added
- File 16849-subversion_repository.dump.gz 16849-subversion_repository.dump.gz added
+1
I think this additional feature will be very useful.
'Anotate' would be better displayed as plain text like the Github 'blame' page.
(eg. https://github.com/ruby/ruby/blame/master/README.md)
I made a patch to preview Markdown and Textile, and attach it.
Updated by Takenori TAKAKI over 3 years ago
I made a patch to preview Markdown and Textile, and attach it.
When changing the repository data to 16849-subversion_repository.dump.gz, the unit test also needed to be changed.
I will post an additional patch.
Updated by Go MAEDA over 3 years ago
Takenori TAKAKI wrote:
I made a patch to preview Markdown and Textile, and attach it.
Thank you for posting the patch.
I suggest adding the following small style changes:
- Add surrounding border as same as #29752#note-7
- Add some margin above the pagination buttons to prevent the border from overlapping with the pagination buttons
diff --git a/public/stylesheets/application.css b/public/stylesheets/application.css
index fca5f5647..d4361bc8c 100644
--- a/public/stylesheets/application.css
+++ b/public/stylesheets/application.css
@@ -789,7 +789,7 @@ span.pagination {margin-left:3px; color:#888; display:block;}
font-weight: bold;
}
span.pagination>span {white-space:nowrap;}
-.controller-attachments.action-show span.pagination{
+.controller-attachments.action-show span.pagination, .controller-repositories.action-entry span.pagination {
display: block;
margin-top: 1.2em;
}
@@ -1804,7 +1804,7 @@ img {
max-width: 100%;
}
-.filecontent-container > .filecontent.wiki {
+#content .filecontent.wiki {
position: relative;
padding: 1em;
border: 1px solid #e4e4e4;
Updated by Go MAEDA over 3 years ago
- Target version set to Candidate for next major release
Updated by Go MAEDA over 3 years ago
- File 16849-v2.patch 16849-v2.patch added
- Subject changed from Add Markdown rendering in Reposotory -> View | Annotate to Render Textile and Markdown files in the repository browser
- Category changed from Text formatting to SCM
- Target version changed from Candidate for next major release to 5.0.0
Applied #16849#note-7 to the patch.
Setting the target version to 5.0.0.
Updated by Go MAEDA over 3 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for improving Redmine.
The repository browser now renders Textile and Markdown files.