Feature #22425
closed
Allow "style" tag in Redcarpet Markdown formatter
Added by Go MAEDA over 8 years ago.
Updated about 2 years ago.
Description
There are no means of styling text (such as color, font-size, ...) in Markdown formetter.
Please allow "style" tag to let users decorate text.
- Subject changed from Allow "style" tag to Allow "style" tag in Markdown formatter
- Related to Feature #2416: {background:color} doesn't work in text formatting added
+1
I also want to set the text color on markdown.
There was a related discussion at the URL below.
https://www.redmine.org/boards/2/topics/56096?r=57052
You can fix it with the following modification,
but I am worried about the security risk.
redmine/lib/redmine/wiki_formatting/markdown/formatter.rb
Redmine::WikiFormatting::Markdown::HTML.new(
:filter_html => false
Wouldn't it be possible to reduce the risk of security by additionally setting safe_links_only => true ?
Redmine::WikiFormatting::Markdown::HTML.new(
:filter_html => false,
:safe_links_only => true
In my environment, I can do these two settings and use the style tag to set the text color.
redcarpet reference
https://github.com/vmg/redcarpet#darling-i-packed-you-a-couple-renderers-for-lunch
- Related to Defect #37237: Common Markdown Formatter does not render all properties on HTML elements added
- Subject changed from Allow "style" tag in Markdown formatter to Allow "style" tag in Redcarpet Markdown formatter
- Status changed from New to Needs feedback
@Go MAEDA: I think we can close this issue as "Wont fix" now that the Redcarpet-based Markdown formatter has been superseded by the new CommonMark Markdown (GitHub Flavored) formatter (#32424) and will be deprecated in 5.1.0 (#36807) and removed in a to-be-determined future release. Do you agree?
- Status changed from Needs feedback to Closed
- Resolution set to Wont fix
Mischa The Evil wrote:
@Go MAEDA: I think we can close this issue as "Wont fix" now that the Redcarpet-based Markdown formatter has been superseded by the new CommonMark Markdown (GitHub Flavored) formatter (#32424) and will be deprecated in 5.1.0 (#36807) and removed in a to-be-determined future release. Do you agree?
Yes, since Redcarpet is going to be removed in the future release and the use of inline styles in CommonMark is discussed in #37237 as you pointed out, I think it is appropriate to close this issue.
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by