Patch #22575
closed
Interesting feature. But I think "Set notes as private" permission should be checked in JournalsController when updating "private" flag.
Go MAEDA wrote:
Interesting feature. But I think "Set notes as private" permission should be checked in JournalsController when updating "private" flag.
Thank you for pointing out the not implemented of permission-check.
I added the permission-check, and re-created the patch.
(Compatible the latest trunk r15361)
Thanks for submitting a new patch. I confirmed that permissions are properly checked when updating the flag.
But I am having some trouble setting private note to public. I cleared "Private notes" check box and saved it, but the note still remains in private. Please see the attached video: cannot-set-private-to-public.mp4
Go MAEDA wrote:
But I am having some trouble setting private note to public. I cleared "Private notes" check box and saved it, but the note still remains in private. Please see the attached video: cannot-set-private-to-public.mp4
Thank you for pointing out my patch's bug. I confirmed same trouble on my environment too...
I Fix the bug, and re-created the patch. Could you please try again the new patch?
Takenori TAKAKI wrote:
I Fix the bug, and re-created the patch. Could you please try again the new patch?
Works fine. Thanks!
- Is duplicate of Feature #12706: Ability to change the private flag when editing a note added
- Target version set to 3.4.0
It looks good to me. Setting target version to 3.4.0.
- Status changed from New to Closed
- Assignee set to Jean-Philippe Lang
- Target version deleted (
3.4.0)
Thanks for the patch. I've made a few changes after that.
Removing it from 3.4.0 as the feature is tracked in #12706.
Also available in: Atom
PDF