Patch #22575: Enable updating private_notes property on journal edit form - Redmine

Actions

Copy link

Patch #22575

closed

Enable updating private_notes property on journal edit form

Added by Takenori TAKAKI over 8 years ago. Updated over 8 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Issues

Target version:

Start date:

Due date:

% Done:

Estimated time:

Description

In current versions of Redmine, users can set 'private' flag when they add new notes, but they don't have any way of updating the flag of existing notes.
I have made the patch, enable to updating `private_notes` property on journal update form.

patch: enable_to_update_private_notes_trunk_r15336.patch

Files

Download all files

updating_private_notes.jpg (65.7 KB) updating_private_notes.jpg		Takenori TAKAKI, 2016-04-18 03:39
enable_to_update_private_notes_trunk_r15336.patch (5.03 KB) enable_to_update_private_notes_trunk_r15336.patch		Takenori TAKAKI, 2016-04-18 03:41
enable_to_update_private_notes_trunk_r15361.patch (5.57 KB) enable_to_update_private_notes_trunk_r15361.patch		Takenori TAKAKI, 2016-04-28 10:12
cannot-set-private-to-public.mp4 (120 KB) cannot-set-private-to-public.mp4		Go MAEDA, 2016-04-30 03:14
enable_to_update_journal_notes_private_or_public_trunk_r15361.patch (5.61 KB) enable_to_update_journal_notes_private_or_public_trunk_r15361.patch		Takenori TAKAKI, 2016-05-02 03:28

Related issues

Actions

Copy link

Updated by Go MAEDA over 8 years ago

Category set to Issues

Actions

Copy link

Updated by Go MAEDA over 8 years ago

Interesting feature. But I think "Set notes as private" permission should be checked in JournalsController when updating "private" flag.

Actions

Copy link

Updated by Takenori TAKAKI over 8 years ago

File enable_to_update_private_notes_trunk_r15361.patch enable_to_update_private_notes_trunk_r15361.patch added

Go MAEDA wrote:

Interesting feature. But I think "Set notes as private" permission should be checked in JournalsController when updating "private" flag.

Thank you for pointing out the not implemented of permission-check.
I added the permission-check, and re-created the patch.
(Compatible the latest trunk r15361)

Actions

Copy link

Updated by Wim DePreter over 8 years ago

+1, and duplicated by #12706

Actions

Copy link

Updated by Go MAEDA over 8 years ago

File cannot-set-private-to-public.mp4 cannot-set-private-to-public.mp4 added

Thanks for submitting a new patch. I confirmed that permissions are properly checked when updating the flag.

But I am having some trouble setting private note to public. I cleared "Private notes" check box and saved it, but the note still remains in private. Please see the attached video: cannot-set-private-to-public.mp4

Actions

Copy link

Updated by Takenori TAKAKI over 8 years ago

File enable_to_update_journal_notes_private_or_public_trunk_r15361.patch enable_to_update_journal_notes_private_or_public_trunk_r15361.patch added

Go MAEDA wrote:

But I am having some trouble setting private note to public. I cleared "Private notes" check box and saved it, but the note still remains in private. Please see the attached video: cannot-set-private-to-public.mp4

Thank you for pointing out my patch's bug. I confirmed same trouble on my environment too...
I Fix the bug, and re-created the patch. Could you please try again the new patch?

Actions

Copy link