Defect #26507: "attachment:filename" link syntax would not work if the file name contains "@" - Redmine

Actions

Defect #26507

closed

"attachment:filename" link syntax would not work if the file name contains "@"

Added by Go MAEDA over 6 years ago. Updated almost 6 years ago.

Status:

Closed

Priority:

Normal

Assignee:

Jean-Philippe Lang

Category:

Text formatting

Target version:

Start date:

Due date:

% Done:

0%

Estimated time:

Resolution:

Fixed

Affected version:

Description

A file name which contains "@" is treated as email address.

Probably all versions that support "attachment:filename" syntax are affected. redmine.org is also affected. Please see this example: wrong-attachment-link@2x.png

[Textile]

attachment:image@2x.png

[Expected output]

<a class="attachment" href="/attachments/***/image@2x.png">image@2x.png</a>

[Actual output]

attachment:<a class="email" href="mailto:image@2x.png">image@2x.png</a>

Files

Download all files

wrong-attachment-link@2x.png (11.1 KB) wrong-attachment-link@2x.png		Go MAEDA, 2017-07-24 06:28
26507_fix_attachment_links_with_@_in_file_name.patch (1.95 KB) 26507_fix_attachment_links_with_@_in_file_name.patch		Marius BĂLTEANU, 2018-04-08 09:26

Related issues

Actions

#1

Updated by Marius BĂLTEANU over 6 years ago

I can work on this, but the fix will be based on the one from #26443.

Actions

#2

Updated by Go MAEDA over 6 years ago

Marius BALTEANU wrote:

I can work on this, but the fix will be based on the one from #26443.

Sounds great. I set the target version of #26443 to 3.4.3. Could you write a patch?

Actions

#3

Updated by Marius BĂLTEANU over 6 years ago

File 26507_fix_attachment_links_with_@_in_file_name added

Go MAEDA wrote:

Sounds great. I set the target version of #26443 to 3.4.3. Could you write a patch?

Here it is. In order to apply this patch, you need to apply first the patch from #26443.

Actions

#4

Updated by Go MAEDA over 6 years ago

Blocked by Defect #26443: User link syntax (user:login) doesn't work for logins consisting of an email adress added

Actions

#5

Updated by Go MAEDA over 6 years ago

Target version set to 3.4.3

The patch looks good to me and passed all tests.
Setting target version to 3.4.3.

Marius, thank you for writing the patch.

Actions

#6

Updated by Marius BĂLTEANU over 6 years ago

File 26507_fix_attachment_links_with_@_in_file_name.patch added

Updated the patch to work with the latest changes from #26443.

Actions

#7

Updated by Marius BĂLTEANU over 6 years ago

File deleted (~~26507_fix_attachment_links_with_@_in_file_name~~)

Actions

#8

Updated by Jean-Philippe Lang over 6 years ago

Target version changed from 3.4.3 to 4.0.0

#26443 is now set for 4.0.

Actions

#9

Updated by Mischa The Evil over 6 years ago

Related to Defect #27968: Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address added

Actions

#10

Updated by Marius BĂLTEANU about 6 years ago

File deleted (~~26507_fix_attachment_links_with_@_in_file_name.patch~~)

Actions

#11

Updated by Marius BĂLTEANU about 6 years ago

File 26507_fix_attachment_links_with_@_in_file_name.patch 26507_fix_attachment_links_with_@_in_file_name.patch added

Updated the patch to apply cleanly against current trunk (r17286).

Actions

#12

Updated by Marius BĂLTEANU about 6 years ago

Status changed from New to Confirmed

Actions

#13

Updated by Jean-Philippe Lang almost 6 years ago

Status changed from Confirmed to Closed
Resolution set to Fixed

Thanks Marius.

Actions

#14

Updated by Go MAEDA almost 6 years ago

Assignee set to Jean-Philippe Lang

Actions

Also available in: Atom PDF