Actions
Defect #26507
closed"attachment:filename" link syntax would not work if the file name contains "@"
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
A file name which contains "@" is treated as email address.
Probably all versions that support "attachment:filename" syntax are affected. redmine.org is also affected. Please see this example: wrong-attachment-link@2x.png
[Textile]
attachment:image@2x.png
[Expected output]
<a class="attachment" href="/attachments/***/image@2x.png">image@2x.png</a>
[Actual output]
attachment:<a class="email" href="mailto:image@2x.png">image@2x.png</a>
Files
Related issues
Updated by Marius BĂLTEANU about 7 years ago
I can work on this, but the fix will be based on the one from #26443.
Updated by Marius BĂLTEANU about 7 years ago
- File 26507_fix_attachment_links_with_@_in_file_name added
Updated by Go MAEDA about 7 years ago
- Blocked by Defect #26443: User link syntax (user:login) doesn't work for logins consisting of an email adress added
Updated by Go MAEDA about 7 years ago
- Target version set to 3.4.3
The patch looks good to me and passed all tests.
Setting target version to 3.4.3.
Marius, thank you for writing the patch.
Updated by Marius BĂLTEANU about 7 years ago
- File 26507_fix_attachment_links_with_@_in_file_name.patch added
Updated the patch to work with the latest changes from #26443.
Updated by Marius BĂLTEANU about 7 years ago
- File deleted (
26507_fix_attachment_links_with_@_in_file_name)
Updated by Jean-Philippe Lang almost 7 years ago
- Target version changed from 3.4.3 to 4.0.0
#26443 is now set for 4.0.
Updated by Mischa The Evil over 6 years ago
- Related to Defect #27968: Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address added
Updated by Marius BĂLTEANU over 6 years ago
- File deleted (
26507_fix_attachment_links_with_@_in_file_name.patch)
Updated by Marius BĂLTEANU over 6 years ago
- File 26507_fix_attachment_links_with_@_in_file_name.patch 26507_fix_attachment_links_with_@_in_file_name.patch added
Updated the patch to apply cleanly against current trunk (r17286).
Updated by Marius BĂLTEANU over 6 years ago
- Status changed from New to Confirmed
Updated by Jean-Philippe Lang about 6 years ago
- Status changed from Confirmed to Closed
- Resolution set to Fixed
Thanks Marius.
Actions