Defect #26507
closed
"attachment:filename" link syntax would not work if the file name contains "@"
Added by Go MAEDA about 7 years ago.
Updated about 6 years ago.
Description
A file name which contains "@" is treated as email address.
Probably all versions that support "attachment:filename" syntax are affected. redmine.org is also affected. Please see this example: wrong-attachment-link@2x.png
[Textile]
attachment:image@2x.png
[Expected output]
<a class="attachment" href="/attachments/***/image@2x.png">image@2x.png</a>
[Actual output]
attachment:<a class="email" href="mailto:image@2x.png">image@2x.png</a>
![](/attachments/download/18815/wrong-attachment-link@2x.png)
Files
I can work on this, but the fix will be based on the one from #26443.
Marius BALTEANU wrote:
I can work on this, but the fix will be based on the one from #26443.
Sounds great. I set the target version of #26443 to 3.4.3. Could you write a patch?
- File 26507_fix_attachment_links_with_@_in_file_name added
Go MAEDA wrote:
Sounds great. I set the target version of #26443 to 3.4.3. Could you write a patch?
Here it is. In order to apply this patch, you need to apply first the patch from #26443.
- Blocked by Defect #26443: User link syntax (user:login) doesn't work for logins consisting of an email adress added
- Target version set to 3.4.3
The patch looks good to me and passed all tests.
Setting target version to 3.4.3.
Marius, thank you for writing the patch.
- File 26507_fix_attachment_links_with_@_in_file_name.patch added
Updated the patch to work with the latest changes from #26443.
- File deleted (
26507_fix_attachment_links_with_@_in_file_name)
- Target version changed from 3.4.3 to 4.0.0
- Related to Defect #27968: Image filename for HDPI monitors (image@2x.jpg) are misrecognized as email address added
- File deleted (
26507_fix_attachment_links_with_@_in_file_name.patch)
Updated the patch to apply cleanly against current trunk (r17286).
- Status changed from New to Confirmed
- Status changed from Confirmed to Closed
- Resolution set to Fixed
- Assignee set to Jean-Philippe Lang
Also available in: Atom
PDF