Defect #28482
closedButtons are disabled when modal is opened again after exporting CSV
0%
Description
- Open issues/index.
- Click on the "CSV" link to open modal.
- Click the export button to export csv.
- After exporting csv, click “CSV" link again to open modal.
Expected result:
By export button, you can export csv again.
Result:
CSV can not be exported because export button and cancel button are disabled.
This is a problem only occurring with the trunk .
I think that the cause of this problem is that disable_with option of submit_tag of rails5 is the default.
( https://github.com/rails/rails/pull/21135 )
disable_with is an option to disable the submit button to prevent duplicate transmission.
The export button and cancel button are disabled at the moment of clicking because disable_with is true.
But that buttons do not reload the screen so the buttons will remain disabled.
I have not confirmed, but there may be other buttons that are in the same state.
Files
Related issues
Updated by Go MAEDA over 6 years ago
- Related to Feature #23630: Migrate to Rails 5.2 added
Updated by Marius BĂLTEANU over 6 years ago
- File 0001-disable-data-disable-with-for-CSV-exports.patch 0001-disable-data-disable-with-for-CSV-exports.patch added
I see two possibility here:
1. Disable this feature in the entire Redmine app by setting config.action_view.automatically_disable_submit_tag = false
in config/application.rb
and enable the feature only where it works as expected (like: #17517).
2. Vice versa, disable only where it doesn't work (like CSV exports).
Because I really like this feature, I would suggest to go with the second option and I made a patch for it.
In addition, I tried to find a way to fix this issue without disabling the data-disable-with feature, but without any luck (excepting adding custom JS code to enable the buttons on show modal).
Also, we should set the target version to 4.0.0. @Go Maeda, can I set it?
Updated by Go MAEDA over 6 years ago
Marius BALTEANU wrote:
Also, we should set the target version to 4.0.0. @Go Maeda, can I set it?
There is no reason why you cannot do it :)
Updated by Go MAEDA over 6 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
- Target version deleted (
4.0.0) - Resolution set to Fixed
Committed. Thanks.
Updated by Mizuki ISHIKAWA over 6 years ago
Thank you for all the actions about this issue!