Previous/Next link on repository page disappear when switching to "View differences" tab
|Assignee:||Go MAEDA||% Done:|
See the screenshots below.
#6 Updated by Mizuki ISHIKAWA almost 3 years ago
Go MAEDA wrote:
The patch breaks some tests. Reverted the change.
I'm sorry, I missed the result of the test.
If you add the following code to the patch of #29730#note-2 , the tests should succeed.
diff --git a/app/views/repositories/diff.html.erb b/app/views/repositories/diff.html.erb index 12875f21ee..3dcc0fdc79 100644 --- a/app/views/repositories/diff.html.erb +++ b/app/views/repositories/diff.html.erb @@ -1,3 +1,4 @@ +<% if @changeset && @changeset_to.nil? %> <div class="contextual"> « <% unless @changeset.previous.nil? -%> @@ -25,7 +26,6 @@ <%= submit_tag 'OK', :name => nil %> <% end %> </div> -<% if @changeset && @changeset_to.nil? %> <%= render :partial => 'changeset' %> <% else %> <h2><%= l(:label_revision) %> <%= @diff_format_revisions %> <%= @path %></h2> diff --git a/tmp/test/empty b/tmp/test/empty deleted file mode 100644 index e69de29bb2..0000000000
#7 Updated by Go MAEDA almost 3 years ago
- Status changed from Reopened to Closed
- Target version deleted (
Candidate for next major release)
Committed the patch again. Thanks.
I don't set the target version of this issue because I think this is a fix for #26576, one of a new feature of Redmine 4.0.0 which is not released yet (no releases are affected by this issue).