Project

General

Profile

Actions

Patch #29830

open

Issue CSV export options: checkboxes have no effect for columns activated in query

Added by Tobias Stenzel over 5 years ago. Updated over 1 year ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Issues
Start date:
Due date:
% Done:

0%

Estimated time:

Description

The csv export option modal for issues has checkboxes for the description and last notes which are activated by default if these columns are activated for the current query. Disabling them manually has no effect: the columns are still exported to CSV because query_as_hidden_field_tags adds them as hidden fields.

This adds an argument ignored_column_names to query_as_hidden_fields_tags which is used to ignore the description and last_notes columns for issues.

Patch works for Redmine 3.4 and 4.


Files


Related issues

Related to Redmine - Patch #33211: Include block columns (ex: Description, Last notes) in CSV export when option "All columns" is selected NewMarius BĂLTEANU

Actions
Actions #1

Updated by Go MAEDA over 5 years ago

  • Target version set to Candidate for next minor release
Actions #2

Updated by Mizuki ISHIKAWA over 5 years ago

Thank you for sharing the patch.

The csv export option modal for issues has checkboxes for the description and last notes which are activated by default if these columns are activated for the current query. Disabling them manually has no effect: the columns are still exported to CSV because query_as_hidden_field_tags adds them as hidden fields.

I felt something wrong with this behavior.

I investigated a little to see if we can solve this problem by changing the view, but it seemed difficult.
I think the method proposed in 0001-fix-Issue-CSV-export-options-checkboxes-have-no-effe.patch is valid.

Actions #3

Updated by Go MAEDA over 5 years ago

  • Target version changed from Candidate for next minor release to 4.1.0
Actions #4

Updated by Ohta Keisuke over 4 years ago

LGTM.
But is it ok to not update tests?

Actions #5

Updated by Go MAEDA over 4 years ago

  • Target version changed from 4.1.0 to 4.2.0
Actions #6

Updated by Marius BĂLTEANU almost 4 years ago

If #33211 is implemented, this change will no longer be required.

Actions #7

Updated by Marius BĂLTEANU almost 4 years ago

  • Related to Patch #33211: Include block columns (ex: Description, Last notes) in CSV export when option "All columns" is selected added
Actions #8

Updated by Marius BĂLTEANU about 3 years ago

  • Target version changed from 4.2.0 to 5.0.0
Actions #9

Updated by Marius BĂLTEANU almost 2 years ago

  • Target version changed from 5.0.0 to Candidate for next major release
Actions #10

Updated by Alexander Meindl over 1 year ago

I updated the patch, which supports Redmine 5.x. Now dynamic block_column names are detected (not manually specified as in first version of patch).

It would be nice, if this patch would be applied soon.

Actions

Also available in: Atom PDF