Patch #29830
open
Issue CSV export options: checkboxes have no effect for columns activated in query
Added by Tobias Stenzel about 6 years ago.
Updated about 2 years ago.
Description
The csv export option modal for issues has checkboxes for the description and last notes which are activated by default if these columns are activated for the current query. Disabling them manually has no effect: the columns are still exported to CSV because query_as_hidden_field_tags
adds them as hidden fields.
This adds an argument ignored_column_names
to query_as_hidden_fields_tags
which is used to ignore the description and last_notes columns for issues.
Patch works for Redmine 3.4 and 4.
Files
- Target version set to Candidate for next minor release
Thank you for sharing the patch.
The csv export option modal for issues has checkboxes for the description and last notes which are activated by default if these columns are activated for the current query. Disabling them manually has no effect: the columns are still exported to CSV because query_as_hidden_field_tags adds them as hidden fields.
I felt something wrong with this behavior.
I investigated a little to see if we can solve this problem by changing the view, but it seemed difficult.
I think the method proposed in 0001-fix-Issue-CSV-export-options-checkboxes-have-no-effe.patch is valid.
- Target version changed from Candidate for next minor release to 4.1.0
LGTM.
But is it ok to not update tests?
- Target version changed from 4.1.0 to 4.2.0
If #33211 is implemented, this change will no longer be required.
- Related to Patch #33211: Include block columns (ex: Description, Last notes) in CSV export when option "All columns" is selected added
- Target version changed from 4.2.0 to 5.0.0
- Target version changed from 5.0.0 to Candidate for next major release
I updated the patch, which supports Redmine 5.x. Now dynamic block_column names are detected (not manually specified as in first version of patch).
It would be nice, if this patch would be applied soon.
Also available in: Atom
PDF