Project

General

Profile

Actions
Copy link

Defect #30718

closed

Translation missing for filter by project status

Added by Vladislav Yashin almost 6 years ago. Updated almost 6 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Issues filter
Target version:
4.0.2
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:
4.0.1

Description

Redmine version: 4.0.1.stable
Ruby version: 2.6.0

Files

Download all files
Снимок экрана 2019-01-30 в 11.44.26.png (30.7 KB) Снимок экрана 2019-01-30 в 11.44.26.png Vladislav Yashin, 2019-01-30 08:44
Screenshot_2019-02-13 Issues.png (6.81 KB) Screenshot_2019-02-13 Issues.png screenshot about issue Lszl Frng, 2019-02-13 17:01
0001-Fix-30718.patch (1.42 KB) 0001-Fix-30718.patch Marius BĂLTEANU, 2019-02-14 22:52
query_test.rb.patch (479 Bytes) query_test.rb.patch Pavel Rosický, 2019-02-15 15:06

Related issues

Related to Redmine - Feature #20081: Filter issues and time entries by project statusClosedGo MAEDA

Actions
Actions
Copy link
 #1

Updated by Bernhard Rohloff almost 6 years ago

I can reproduce this issue on my upgraded production instance. Surprisingly it doesn't occur in my development setup.

Actions
Copy link
 #2

Updated by Lszl Frng almost 6 years ago

The problem is also present in version 4.0.0.stable

Environment:
Redmine version 4.0.0.stable
Ruby version 2.5.1-p57 (2018-03-29) [x86_64-linux-gnu]
Rails version 5.2.2
Environment production
Database adapter Mysql2
Mailer queue ActiveJob::QueueAdapters::AsyncAdapter
Mailer delivery smtp
SCM:
Subversion 1.9.7
Git 2.17.1
Filesystem
Redmine plugins:
redmine_agile 1.4.7
redmine_issue_dynamic_edit 0.6.5
redmine_lightbox2 0.5.0

Actions
Copy link
 #3

Updated by Marius BĂLTEANU almost 6 years ago

  • Assignee set to Marius BĂLTEANU
Actions
Copy link
 #4

Updated by Pavel Rosický almost 6 years ago

I can confirm the problem.

status translations are evaluated only once during start of the server, see
https://github.com/redmine/redmine/blob/4e9886f9b5d4df10cd76d67312c06b8af5a17903/app/models/project.rb#L28

as a result it'll always be in english or translation missing (in combination with some 3rd party plugins).

QueryTest#test_project_statuses_values_should_return_only_active_and_closed_statuses should also be fixed because the test always expects english strings even if the current locale is different

Expected: [["active", "1"], ["closed", "5"]]
  Actual: [["actif", "1"], ["fermé", "5"]]
Actions
Copy link
 #5

Updated by Marius BĂLTEANU almost 6 years ago

  • Related to Feature #20081: Filter issues and time entries by project status added
Actions
Copy link
 #6

Updated by Marius BĂLTEANU almost 6 years ago

  • File fix_for_30718.patch added

Could you test, please, the attached patch and tell me if it fixes the problem?

Actions
Copy link
 #7

Updated by Marius BĂLTEANU almost 6 years ago

  • File deleted (fix_for_30718.patch)
Actions
Copy link
 #9

Updated by Pavel Rosický almost 6 years ago

works fine, thanks

Actions
Copy link
 #10

Updated by Marius BĂLTEANU almost 6 years ago

  • Target version set to 4.0.2
Actions
Copy link
 #11

Updated by Marius BĂLTEANU almost 6 years ago

  • Assignee deleted (Marius BĂLTEANU)

Patches to commit:
1. 0001-Fix-30718.patch
2. query_test.rb.patch

Actions
Copy link
 #12

Updated by Go MAEDA almost 6 years ago

  • Status changed from New to Resolved
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed. Thank you all for reporting, investigating, and fixing this issue.

Actions
Copy link
 #13

Updated by Go MAEDA almost 6 years ago

  • Status changed from Resolved to Closed

Merged to 4.0-stable branch.

Actions
Copy link

Also available in: Atom PDF