Feature #31472
open
Add file upload when editing documents
0%
Description
On documents module, add/edit/remove attachments is missing when document is edited...
Files
Updated by Yuichi HARADA almost 4 years ago
- File change_editing_document.png change_editing_document.png added
- File 31472-add-file-upload.patch 31472-add-file-upload.patch added
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.
Updated by Mischa The Evil almost 4 years ago
- Target version set to Unplanned backlogs
Sweet! Thanks for sharing the patch. Scheduled without substantive patch review.
NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.
Updated by Yuichi HARADA over 3 years ago
Mischa The Evil wrote:
NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.
Thank you for your suggestions. I would be happy if you could create new issues.
Updated by Yuichi HARADA over 2 years ago
Yuichi HARADA wrote:
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.
When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk was not executed.
I fixed a patch.
Updated by Yuichi HARADA over 2 years ago
Yuichi HARADA wrote:
Yuichi HARADA wrote:
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.When performing bulk delete, the Attachment's after_commit callback method
Attachment#delete_from_diskwas not executed.
I fixed a patch.
I have improved Document#delete_selected_attachments.