Feature #31472

Add file upload when editing documents

Added by Aleksandar Pavic about 2 years ago. Updated 4 months ago.

Status:NewStart date:
Priority:NormalDue date:
Assignee:-% Done:

0%

Category:Documents
Target version:Unplanned backlogs
Resolution:

Description

On documents module, add/edit/remove attachments is missing when document is edited...

change_editing_document.png (152 KB) Yuichi HARADA, 2019-12-18 02:19

31472-add-file-upload.patch Magnifier (6.49 KB) Yuichi HARADA, 2019-12-18 02:21

31472-add-file-upload-v2.patch Magnifier (6.57 KB) Yuichi HARADA, 2021-03-12 06:41

31472-add-file-upload-v3.patch Magnifier (6.6 KB) Yuichi HARADA, 2021-03-12 08:26

History

#1 Updated by Yuichi HARADA over 1 year ago

This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.

#2 Updated by Mischa The Evil over 1 year ago

  • Target version set to Unplanned backlogs

Sweet! Thanks for sharing the patch. Scheduled without substantive patch review.

NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.

#3 Updated by Yuichi HARADA 10 months ago

Mischa The Evil wrote:

NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.

Thank you for your suggestions. I would be happy if you could create new issues.

#4 Updated by Yuichi HARADA 4 months ago

Yuichi HARADA wrote:

This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.

When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk was not executed.
I fixed a patch.

#5 Updated by Yuichi HARADA 4 months ago

Yuichi HARADA wrote:

Yuichi HARADA wrote:

This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.

When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk was not executed.
I fixed a patch.

I have improved Document#delete_selected_attachments.

Also available in: Atom PDF