Feature #31472
Add file upload when editing documents
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | Documents | |||
| Target version: | Unplanned backlogs | |||
| Resolution: |
Description
On documents module, add/edit/remove attachments is missing when document is edited...
change_editing_document.png (152 KB)
31472-add-file-upload.patch 
(6.49 KB)
31472-add-file-upload-v2.patch
(6.57 KB)
31472-add-file-upload-v3.patch
(6.6 KB)
History
#1
Updated by Yuichi HARADA almost 2 years ago
- File change_editing_document.png added
- File 31472-add-file-upload.patch added
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.
#2
Updated by Mischa The Evil almost 2 years ago
- Target version set to Unplanned backlogs
Sweet! Thanks for sharing the patch. Scheduled without substantive patch review.
NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.
#3
Updated by Yuichi HARADA about 1 year ago
Mischa The Evil wrote:
NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.
Thank you for your suggestions. I would be happy if you could create new issues.
#4
Updated by Yuichi HARADA 6 months ago
- File 31472-add-file-upload-v2.patch added
Yuichi HARADA wrote:
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.
When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk was not executed.
I fixed a patch.
#5
Updated by Yuichi HARADA 6 months ago
- File 31472-add-file-upload-v3.patch added
Yuichi HARADA wrote:
Yuichi HARADA wrote:
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.When performing bulk delete, the Attachment's after_commit callback method
Attachment#delete_from_diskwas not executed.
I fixed a patch.
I have improved Document#delete_selected_attachments.