Project

General

Profile

Actions
Copy link

Feature #31472

open

Add file upload when editing documents

Added by Aleksandar Pavic over 5 years ago. Updated 4 months ago.

Status:
New
Priority:
Normal
Assignee:
-
Category:
Documents
Target version:
Unplanned backlogs
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

On documents module, add/edit/remove attachments is missing when document is edited...

Files

Download all files
change_editing_document.png (152 KB) change_editing_document.png Yuichi HARADA, 2019-12-18 02:19
31472-add-file-upload.patch (6.49 KB) 31472-add-file-upload.patch Yuichi HARADA, 2019-12-18 02:21
31472-add-file-upload-v2.patch (6.57 KB) 31472-add-file-upload-v2.patch Yuichi HARADA, 2021-03-12 06:41
31472-add-file-upload-v3.patch (6.6 KB) 31472-add-file-upload-v3.patch Yuichi HARADA, 2021-03-12 08:26
31472-add-file-upload-v5.1.patch (6.52 KB) 31472-add-file-upload-v5.1.patch de zhang, 2024-07-29 03:55
Actions
Copy link
 #1

Updated by Yuichi HARADA almost 5 years ago

This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.

Actions
Copy link
 #2

Updated by Mischa The Evil almost 5 years ago

  • Target version set to Unplanned backlogs

Sweet! Thanks for sharing the patch. Scheduled without substantive patch review.

NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.

Actions
Copy link
 #3

Updated by Yuichi HARADA over 4 years ago

Mischa The Evil wrote:

NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.

Thank you for your suggestions. I would be happy if you could create new issues.

Actions
Copy link
 #4

Updated by Yuichi HARADA over 3 years ago

Yuichi HARADA wrote:

This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.

When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk was not executed.
I fixed a patch.

Actions
Copy link
 #5

Updated by Yuichi HARADA over 3 years ago

Yuichi HARADA wrote:

Yuichi HARADA wrote:

This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.

When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk was not executed.
I fixed a patch.

I have improved Document#delete_selected_attachments.

Actions
Copy link
 #6

Updated by de zhang 4 months ago

Yuichi HARADA wrote in #note-5:

Yuichi HARADA wrote:

Yuichi HARADA wrote:

This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.

When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk was not executed.
I fixed a patch.

I have improved Document#delete_selected_attachments.

Thank you for your code. I have ported the 31472-add-file-upload-v3 to Redmine V5.1

Actions
Copy link

Also available in: Atom PDF