Feature #31472
open
Add file upload when editing documents
Added by Aleksandar Pavic almost 5 years ago.
Updated about 3 years ago.
Description
On documents module, add/edit/remove attachments is missing when document is edited...
Files
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.
- Target version set to Unplanned backlogs
Sweet! Thanks for sharing the patch. Scheduled without substantive patch review.
NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.
Mischa The Evil wrote:
NB: I think it would be nice to introduce this functionality similarly for the remaining attachment containers (news and messages) too.
Thank you for your suggestions. I would be happy if you could create new issues.
Yuichi HARADA wrote:
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.
When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk
was not executed.
I fixed a patch.
Yuichi HARADA wrote:
Yuichi HARADA wrote:
This patch adds features similar to #16410 to the documents.
When editing a document, you can operate (add and bulk delete) the attachments.
When performing bulk delete, the Attachment's after_commit callback method Attachment#delete_from_disk
was not executed.
I fixed a patch.
I have improved Document#delete_selected_attachments
.
Also available in: Atom
PDF