Defect #31552: View switches from gantt to list after editing an issue - Redmine

Defect #31552

View switches from gantt to list after editing an issue

Added by Bernhard Rohloff over 2 years ago. Updated about 2 years ago.

Status:

Closed

Start date:

Priority:

Normal

Due date:

Assignee:

Go MAEDA

% Done:

Category:

Gantt

Target version:

4.0.5

Resolution:

Fixed

Affected version:

Description

The view is only affected if a custom filter is applied. If there's
no filter applied the view works as expected.

Steps to reproduce

Open the gantt view.
Modify and apply the filter.
Edit an issue with the right click menu

Result

The view switches to the issues list view

Expected result

The view stays on the gantt view

gantt_switch_to_list_issue.webm - Video showing the behavior with and without custom filter (179 KB) Bernhard Rohloff, 2019-06-11 11:52

add-back-url-parameter.patch (1.41 KB) Mizuki ISHIKAWA, 2019-06-27 09:09

Related issues

Associated revisions

Revision 18322
Added by Go MAEDA about 2 years ago

View switches from gantt to list after editing an issue (#31552).

Patch by Mizuki ISHIKAWA.

Revision 18324
Added by Go MAEDA about 2 years ago

Merged r18322 from trunk to 4.0-stable (#31552).

History

#1 Updated by Go MAEDA over 2 years ago

Status changed from New to Confirmed

#2 Updated by Mizuki ISHIKAWA about 2 years ago

I have confirmed that the changes below fix this problem.

diff --git a/app/controllers/application_controller.rb b/app/controllers/application_controller.rb
index 06e2d702c1..afbb30f3ee 100644
--- a/app/controllers/application_controller.rb
+++ b/app/controllers/application_controller.rb
@@ -440,7 +440,7 @@ class ApplicationController < ActionController::Base
     end

     begin
-      uri = URI.parse(back_url)
+      uri = URI.parse(URI.encode(back_url))
     rescue URI::InvalidURIError
       return false
     end

However, I am concerned that this change will cause other problems.
ApplicationController#validate_back_url is a method that includes security changes(#19577), so it needs to be corrected carefully.