Project

General

Profile

Actions

Defect #32765

closed

##123 syntax for linking to issues: Title cannot be distinguished from following text

Added by Robert Schneider almost 5 years ago. Updated over 4 years ago.

Status:
Closed
Priority:
Normal
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Relates to #29488.

The displayed title of the linked issue has the same style as the normal text, what could lead to confusing information. A minimal fix would be to add the link color also to the title (bold or not bold).


Files

highlight.png (108 KB) highlight.png Marius BĂLTEANU, 2020-01-12 21:05
link.png (105 KB) link.png Marius BĂLTEANU, 2020-01-12 21:05
fix_32765.patch (4.7 KB) fix_32765.patch Marius BĂLTEANU, 2020-01-21 21:50
fix_32765_v2.patch (4.57 KB) fix_32765_v2.patch Marius BĂLTEANU, 2020-04-05 11:07

Related issues

Related to Redmine - Patch #29488: ##123 syntax for linking to issues with tracker name and subjectClosedGo MAEDA

Actions
Actions #1

Updated by Go MAEDA almost 5 years ago

  • Related to Patch #29488: ##123 syntax for linking to issues with tracker name and subject added
Actions #2

Updated by Marius BĂLTEANU almost 5 years ago

I agree that we should have different styles.

Attached two screenshots:
1. Subject as link (as Robert proposed)

2. Highlight the entire text using the style from inline code:

Actions #3

Updated by Bernhard Rohloff almost 5 years ago

I think formatting the subject as link is more consistent and fits better than the inline code style.
+1 for the link variant.

Actions #4

Updated by Go MAEDA almost 5 years ago

I prefer the first option (render subject as link). It is consistent with links to other objects such as message and user.

Actions #5

Updated by Jean-Philippe Lang almost 5 years ago

  • Target version set to 4.1.1
Actions #6

Updated by Marius BĂLTEANU almost 5 years ago

Here is a patch that includes the subject in the linked text, but I think that we should change the title as well because right now we show the entire subject and the title shows the subject truncated at 100 characters and the status. Maybe it is enough to show "label_status: status".

Actions #7

Updated by Go MAEDA over 4 years ago

Marius BALTEANU wrote:

but I think that we should change the title as well because right now we show the entire subject and the title shows the subject truncated at 100 characters and the status. Maybe it is enough to show "label_status: status".

I agree.

Actions #8

Updated by Marius BĂLTEANU over 4 years ago

Go MAEDA wrote:

Marius BALTEANU wrote:

but I think that we should change the title as well because right now we show the entire subject and the title shows the subject truncated at 100 characters and the status. Maybe it is enough to show "label_status: status".

I agree.

Updated the patch.

Actions #9

Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from New to Resolved
  • Assignee set to Jean-Philippe Lang
  • Resolution set to Fixed

Patch committed, thanks!

Actions #10

Updated by Jean-Philippe Lang over 4 years ago

  • Status changed from Resolved to Closed

Merged.

Actions

Also available in: Atom PDF