Project

General

Profile

Actions

Defect #33341

closed

Time entry user is shown twice in the User drop-down when editing spent time

Added by Thomas Löber about 4 years ago. Updated about 4 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
Time tracking
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed
Affected version:

Description

Hi,

When editing Spent Time the current time entry user is shown twice in the User drop-down.

This is because the condition to add the current time entry user to the collection is wrong in TimelogHelper#user_collection_for_select_options.

It is:

collection << time_entry.user unless time_entry.user.nil? && !collection.include?(time_entry.user)

But it should be:

collection << time_entry.user if time_entry.user && !collection.include?(time_entry.user)

Best regards,
Thomas


Files


Related issues

Related to Redmine - Defect #32973: Editing a time entry for a locked user changes the user to the current userClosedJean-Philippe Lang

Actions
Actions

Also available in: Atom PDF