Defect #35090
closedPermission check of the setting button on the issues page mismatches button semantics
0%
Description
In source:/tags/4.2.0/app/views/issues/index.html.erb#L16 the link goes to the issues
tab of the project settings. The button is only shown if the user has the manage_categories
permission but the permission required for this tab is edit_project
source:/tags/4.2.0/app/helpers/projects_helper.rb#L28
Note that this is only a UI issue, the button might be shown to users that cannot see the tab that it links to or the button might not be shown to users that would be able to see the tab that it links too, but upon following the link the correct permission is checked. There also is no information disclosure associated with this issue.
Files
Related issues
Updated by Takenori TAKAKI about 3 years ago
- File fix-35090.patch fix-35090.patch added
I made a patch to fix & test the issue #35090, and attach it.
Updated by Go MAEDA about 3 years ago
- Related to Feature #22090: Make project settings more accessible added
Updated by Go MAEDA about 3 years ago
- Status changed from New to Confirmed
- Target version set to 4.1.5
Setting the target version to 4.1.5.
Updated by Go MAEDA about 3 years ago
- Target version changed from 4.1.5 to 4.1.6
Updated by Go MAEDA almost 3 years ago
- Subject changed from Permission check mismatches button semantics to Permission check of the setting button on the issues page mismatches button semantics
- Status changed from Confirmed to Resolved
- Assignee set to Go MAEDA
- Resolution set to Fixed
Committed the patch. Thank you for your contribution.