Feature #35189
closed
New email notification option "For any event on my bookmarked projects"
Added by Yoann AMICHAUD over 3 years ago.
Updated 10 months ago.
Category:
Email notifications
Description
For now, if you want to be informed about all events of a huge projects portfolio, I have to update the list behind "For any events of the selected projects only..." quite often.
It would be really great if we can receive all notifications of the bookmarked projects adding a new option in the notification option list : "For any events of my bookmarked projects only..."
Files
- Target version set to Candidate for next major release
I wrote a patch to add this feature.
- Target version changed from Candidate for next major release to 5.1.0
Setting the target version to 5.1.0.
I think the most similar existing notification option to the new option that the patch implement is "For any event on the selected projects only..." (internal name: "selected"), so I suggest changing the internal name of the option from "only_bookmarked_projects" to "bookmarked".
Here is an updated patch.
Updated the patch to remove repeated code from User#update_notified_project_ids.
- File feature-35189-v3.patch added
@Go Maeda, what do you think about the reworked attached patch? I tried to simplify the code a little bit.
- File deleted (
feature-35189-v3.patch)
@Go MAEDA, I'm assign you to review the patch and to commit it if the changes are ok.
- Subject changed from New email notification option - events of my bookmarked projects to New email notification option "For any event on my bookmarked projects"
- Status changed from New to Closed
- Resolution set to Fixed
Committed the patch. Thank you.
Marius BALTEANU wrote in #note-6:
@Go Maeda, what do you think about the reworked attached patch? I tried to simplify the code a little bit.
Thank you for improving the patch!
- Related to Defect #39854: "For any event on my bookmarked projects" option not sending notifications for non-member bookmarked projects added
- Assignee changed from Go MAEDA to Marius BĂLTEANU
- Target version deleted (
6.0.0)
- Resolution changed from Fixed to Wont fix
I've reverted the changes added here after we agreed that handling notifications based on the bookmarked flag is not the best ideea (please see the discussions from #39854).
We will improve the notification settings to allow users to easier watch projects (including public projects).
- Has duplicate Feature #15542: "For any event on the selected projects only" as a star on project overview added
Also available in: Atom
PDF