Defect #35957

MessagesControllerTest#test_post_new test fails (trunk)

Added by Mizuki ISHIKAWA 11 months ago. Updated 10 months ago.

Status:ClosedStart date:
Priority:NormalDue date:
Assignee:Marius BALTEANU% Done:

0%

Category:Code cleanup/refactoring
Target version:-
Resolution:Fixed Affected version:

Description

Failure:
MessagesControllerTest#test_post_new [/usr/src/redmine/test/functional/messages_controller_test.rb:163]:
Expected: ["jsmith@somenet.foo"]
  Actual: ["dlopper@somenet.foo"]

rails test test/functional/messages_controller_test.rb:131

There is no guarantee that the elements will be in the order of "first: author, second: member" in the array mails, so the test should be modified so that it does not depend on the order.

I've had the same problem before and fixed it(#34169), but the change in r21130 seems to have caused the problem again.

fix-test.patch Magnifier (715 Bytes) Mizuki ISHIKAWA, 2021-10-06 10:16


Related issues

Related to Redmine - Feature #30820: Drop setting "Blind carbon copy recipients (bcc)" Closed

Associated revisions

Revision 21242
Added by Marius BALTEANU 10 months ago

Fix random failing test introduced in r21130 (#35957, #34169).

History

#1 Updated by Mizuki ISHIKAWA 11 months ago

A patch for the fix is attached.

#2 Updated by Marius BALTEANU 11 months ago

  • Status changed from New to Confirmed
  • Assignee set to Marius BALTEANU

#3 Updated by Go MAEDA 11 months ago

  • Description updated (diff)

#4 Updated by Marius BALTEANU 10 months ago

  • Status changed from Confirmed to Closed
  • Resolution set to Fixed

Committed, thanks!

#5 Updated by Go MAEDA 10 months ago

  • Related to Feature #30820: Drop setting "Blind carbon copy recipients (bcc)" added

Also available in: Atom PDF