Project

General

Profile

Actions

Patch #36429

closed

Make issue tabs DOM more consistent

Added by Felix Schäfer about 2 years ago. Updated about 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Category:
UI
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:

Description

It is currently difficult to consistently style the tabs in the issue history because the DOMs are different.


Files


Related issues

Related to Redmine - Patch #31573: Show each journal entry from issue history in a boxNewMarius BĂLTEANU

Actions
Actions #1

Updated by Felix Schäfer about 2 years ago

The attached patch makes the DOM for the time spent and change sets tabs more consistent with the history tabs.

Actions #2

Updated by Bernhard Rohloff about 2 years ago

Patch looks good to me...
+1

Actions #3

Updated by Go MAEDA about 2 years ago

  • Target version set to 5.0.0

Setting the target version to 5.0.0.

Actions #4

Updated by Dmitry Makurin about 2 years ago

Marius did a great job in #31573. I guess this and #31573 could be done in one series of patches since both issues have the same purpose.

Actions #5

Updated by Go MAEDA about 2 years ago

Dmitry Makurin wrote:

Marius did a great job in #31573. I guess this and #31573 could be done in one series of patches since both issues have the same purpose.

I would like to commit this patch first without waiting for the result of the discussion on #31573.

This patch just fixes the consistency of DOM and makes it easy for theme developers to apply styles. This is a necessary fix regardless of whether we merge #31573 or not. And this patch does not have a significant negative impact on #31573.

Actions #6

Updated by Go MAEDA about 2 years ago

  • Subject changed from Make issue tabs more consistent to Make issue tabs DOM more consistent
  • Status changed from New to Closed
  • Assignee set to Go MAEDA

Committed the patch. Thank you.

Actions #7

Updated by Marius BĂLTEANU about 2 years ago

  • Related to Patch #31573: Show each journal entry from issue history in a box added
Actions

Also available in: Atom PDF