Patch #36493
Update Polish translation
| Status: | Closed | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: |  Go MAEDA | % Done: | 0% | |
| Category: | Translations | |||
| Target version: | - |
Description
Follow up for #33361.
Also, I would appreciate it if you don't change order of translations. In #33361 I intentionally restored order from en.yml, and while it makes this initial diff quite big, it also simplifies translation process, since I can compare translations with English strings side by side (example).
pl.yml 
(71.8 KB)
pl.patch
(129 KB)
pl.yml
- Updated for r21395
(72.1 KB)
pl.patch
- Updated for r21395
(130 KB)
pl-step1.patch
(116 KB)
pl-step1.yml
(72.1 KB)
pl-step2.yml
(72.1 KB)
pl-step2.patch
(29.9 KB)
Associated revisions
Reorder keys in pl.yml to the same order with en.yml (#36493).
Patch by Robert Korulczyk.
Polish translation update (#36493).
Patch by Robert Korulczyk.
History
#2
Updated by Go MAEDA 3 months ago
Robert Korulczyk wrote:
Also, I would appreciate it if you don't change order of translations.
Can you split the patch into two patches? The first patch just changes the order of labels and the second patch updates translations. This makes it easier to track changes in the repository.
#3
Updated by Robert Korulczyk 3 months ago
- File pl-step1.patch added
- File pl-step1.yml added
- File pl-step2.patch added
- File pl-step2.yml added
Go MAEDA wrote:
Can you split the patch into two patches? The first patch just changes the order of labels and the second patch updates translations. This makes it easier to track changes in the repository.
Done.
#5
Updated by Robert Korulczyk 3 months ago
Go MAEDA wrote:
Thank you for posting the new patches but I found some reordering also in pl-step2.patch. I will try to update the patches.
These are new untranslated phrases moved to correct place. If you revert reordering, they will be a problem for future translations, since order of phrases will not match original from en.yml.
I based step1 on original patch from #33361 with new phrases added since then (which are added at the end). If such reordering is a problem, then maybe rake locales:update would be able to respect order from en.yml?