Patch #36493
closed
Update Polish translation
Added by Robert Korulczyk almost 3 years ago. Updated about 2 years ago.
0%
Description
Follow up for #33361.
Also, I would appreciate it if you don't change order of translations. In #33361 I intentionally restored order from en.yml, and while it makes this initial diff quite big, it also simplifies translation process, since I can compare translations with English strings side by side (example).
Files
| pl.yml (71.8 KB) pl.yml | Robert Korulczyk, 2022-01-22 16:47 | ||
| pl.patch (129 KB) pl.patch | Robert Korulczyk, 2022-01-22 16:47 | ||
| pl.yml (72.1 KB) pl.yml | Updated for r21395 | Robert Korulczyk, 2022-02-12 23:44 | |
| pl.patch (130 KB) pl.patch | Updated for r21395 | Robert Korulczyk, 2022-02-12 23:44 | |
| pl-step1.patch (116 KB) pl-step1.patch | Robert Korulczyk, 2022-02-20 12:44 | ||
| pl-step1.yml (72.1 KB) pl-step1.yml | Robert Korulczyk, 2022-02-20 12:44 | ||
| pl-step2.yml (72.1 KB) pl-step2.yml | Robert Korulczyk, 2022-02-20 12:44 | ||
| pl-step2.patch (29.9 KB) pl-step2.patch | Robert Korulczyk, 2022-02-20 12:44 | ||
| pl.patch (451 Bytes) pl.patch | Robert Korulczyk, 2022-10-21 17:15 |
Updated by Robert Korulczyk almost 3 years ago
Updated translations after r21395.
Updated by Go MAEDA almost 3 years ago
Robert Korulczyk wrote:
Also, I would appreciate it if you don't change order of translations.
Can you split the patch into two patches? The first patch just changes the order of labels and the second patch updates translations. This makes it easier to track changes in the repository.
Updated by Robert Korulczyk almost 3 years ago
- File pl-step1.patch pl-step1.patch added
- File pl-step1.yml pl-step1.yml added
- File pl-step2.patch pl-step2.patch added
- File pl-step2.yml pl-step2.yml added
Go MAEDA wrote:
Can you split the patch into two patches? The first patch just changes the order of labels and the second patch updates translations. This makes it easier to track changes in the repository.
Done.
Updated by Go MAEDA over 2 years ago
Thank you for posting the new patches but I found some reordering also in pl-step2.patch. I will try to update the patches.
Updated by Robert Korulczyk over 2 years ago
Go MAEDA wrote:
Thank you for posting the new patches but I found some reordering also in pl-step2.patch. I will try to update the patches.
These are new untranslated phrases moved to correct place. If you revert reordering, they will be a problem for future translations, since order of phrases will not match original from en.yml.
I based step1 on original patch from #33361 with new phrases added since then (which are added at the end). If such reordering is a problem, then maybe rake locales:update would be able to respect order from en.yml?
Updated by Go MAEDA over 2 years ago
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the translations. Thank you for your contribution.
Updated by Marcin Szewczyk about 2 years ago
There is a serious mistake in the translation - uppercase boolean values are inverted!
general_text_No: 'Tak' general_text_Yes: 'Nie' general_text_no: 'nie' general_text_yes: 'tak'
Should be:
general_text_No: 'Nie' general_text_Yes: 'Tak' general_text_no: 'nie' general_text_yes: 'tak'
Problem introduced in r21449.
Updated by Robert Korulczyk about 2 years ago
Marcin Szewczyk wrote:
There is a serious mistake in the translation - uppercase boolean values are inverted!
[...]
Should be:
[...]Problem introduced in r21449.
Sorry about that. I'm attaching a patch to fix this regression.
Updated by Go MAEDA about 2 years ago
- Status changed from Reopened to Closed