Patch #36493
closed
Update Polish translation
Added by Robert Korulczyk over 2 years ago.
Updated over 1 year ago.
Description
Follow up for #33361.
Also, I would appreciate it if you don't change order of translations. In #33361 I intentionally restored order from en.yml
, and while it makes this initial diff quite big, it also simplifies translation process, since I can compare translations with English strings side by side (example).
Files
Updated translations after r21395.
Robert Korulczyk wrote:
Also, I would appreciate it if you don't change order of translations.
Can you split the patch into two patches? The first patch just changes the order of labels and the second patch updates translations. This makes it easier to track changes in the repository.
Go MAEDA wrote:
Can you split the patch into two patches? The first patch just changes the order of labels and the second patch updates translations. This makes it easier to track changes in the repository.
Done.
Thank you for posting the new patches but I found some reordering also in pl-step2.patch. I will try to update the patches.
Go MAEDA wrote:
Thank you for posting the new patches but I found some reordering also in pl-step2.patch. I will try to update the patches.
These are new untranslated phrases moved to correct place. If you revert reordering, they will be a problem for future translations, since order of phrases will not match original from en.yml.
I based step1 on original patch from #33361 with new phrases added since then (which are added at the end). If such reordering is a problem, then maybe rake locales:update
would be able to respect order from en.yml
?
- Status changed from New to Closed
- Assignee set to Go MAEDA
Committed the translations. Thank you for your contribution.
There is a serious mistake in the translation - uppercase boolean values are inverted!
general_text_No: 'Tak'
general_text_Yes: 'Nie'
general_text_no: 'nie'
general_text_yes: 'tak'
Should be:
general_text_No: 'Nie'
general_text_Yes: 'Tak'
general_text_no: 'nie'
general_text_yes: 'tak'
Problem introduced in r21449.
Marcin Szewczyk wrote:
There is a serious mistake in the translation - uppercase boolean values are inverted!
[...]
Should be:
[...]
Problem introduced in r21449.
Sorry about that. I'm attaching a patch to fix this regression.
- Status changed from Reopened to Closed
Marcin Szewczyk wrote:
There is a serious mistake in the translation - uppercase boolean values are inverted!
[...]
Should be:
[...]
Problem introduced in r21449.
I have opened a new issue #37812 for this. Thank you for reporting.
Also available in: Atom
PDF