Project

General

Profile

Actions
Copy link

Feature #36701

closed

Update Chart.js to 3.7.1

Added by Maciej Pankanin over 2 years ago. Updated over 2 years ago.

Status:
Closed
Priority:
Normal
Assignee:
Go MAEDA
Category:
Third-party libraries
Target version:
5.0.0
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:
Fixed

Description

Redmine is now using 2.8.0 which was released almost 3 years ago (14 Mar 2019). There are use cases in which plugin developers would want to use Chart.js but to use latest features they have to ship another js bundle.

Chart.js 2.8.0
Chart.js 3.7.1

I looked into code, there are only few usages, so it should not be hard to upgrade.

Also it would be nice to upgrade jQuery to latest (3.6.0 atm).
I wonder why jQuery is shipped in single bundle with jQueryUI and Rails UJS making them harder to upgrade.

Files

update_chartjs.patch (400 KB) update_chartjs.patch Maciej Pankanin, 2022-02-25 20:11
Actions
Copy link
 #1

Updated by Marius BĂLTEANU over 2 years ago

Please see #35729 for jQuery 3.6.0.

I'm in favour of updating the Chart.js library.

Actions
Copy link
 #3

Updated by Go MAEDA over 2 years ago

  • Target version set to 5.0.0

Thank you for posting the patch. Charts on Issue summary page and repository page are displayed without problem.

Setting the target version to 5.0.0.

Actions
Copy link
 #4

Updated by Go MAEDA over 2 years ago

  • Subject changed from Update Chart.js to latest (3.7.1) to Update Chart.js to 3.7.1
  • Status changed from New to Closed
  • Assignee set to Go MAEDA
  • Resolution set to Fixed

Committed the patch. Thank you for your contribution.

Actions
Copy link

Also available in: Atom PDF