Defect #36887
closed
copyImageFromClipboard function failed to generate a unique file name
Added by Simon Hori over 2 years ago.
Updated over 2 years ago.
Description
Hello,
The function copyImageFromClipboard is NOT generating unique file name but always uploading image.png.
I've confirmed the problem in chrome 99.0.4844.74, edge 100.0.1185.29, firefox 98.0.2.
This is our environment.
Environment:
Redmine version 4.2.5.stable
Ruby version 2.6.9-p207 (2021-11-24) [x86_64-linux-musl]
Rails version 5.2.6.3
Environment production
Database adapter PostgreSQL
Mailer queue ActiveJob::QueueAdapters::AsyncAdapter
Mailer delivery smtp
Possible reason:
According from the public/javascripts/attachments.js#L283-L291 I felt that the variable 'filename' is defined but not used. Can it be the reason of this behavior?
Thank you very much for your support.
Files
- Copied from Patch #36817: copyImageFromClipboard function targets the first file input of the page and may conflict with other plugins added
I am sorry Marius BALTEANU. Maybe I shouldn't have copied #36817 with the target version and the assignee. Please let me know if I should create a new issue from scratch.
- Status changed from New to Confirmed
- File 0001-Fix-copyImageFromClipboard-function-failed-to-genera.patch added
Simon, thanks for reporting this! Can you test the attached fix?
- File deleted (
0001-Fix-copyImageFromClipboard-function-failed-to-genera.patch)
Awesome!! It works, thank you so much for the quick fix.
Screenshot
- Status changed from Confirmed to Resolved
- Resolution set to Fixed
- Related to Defect #36911: Clipboard copy is broken after upgrade to 4.2.5 or 5.0.0 from 4.2.3 added
- Related to deleted (Defect #36911: Clipboard copy is broken after upgrade to 4.2.5 or 5.0.0 from 4.2.3)
- Has duplicate Defect #36911: Clipboard copy is broken after upgrade to 4.2.5 or 5.0.0 from 4.2.3 added
- Related to Defect #36013: Paste image mixed with other DataTransferItem added
Merged to stable branches, but I will keep this open for a few days, I would like to try add a system test.
- Status changed from Resolved to Closed
I didn't find a way to add a test for this, any help is welcome.
Also available in: Atom
PDF