Defect #37730
closedMissing copyright headers in source files
0%
Description
The source files in the following list are missing proper copyright headers:
Given that all these files are distributed as part of the Redmine core, I'd say that it would be correct if each of them would contain appropriate copyright headers (even the plugin initialization, rake task and CSS files).
1 since the content of this file is derived from DotClear, it might be correct to add the original DotClear copyright headers (like e.g. source:/trunk/public/javascripts/jstoolbar) to this file.
Files
Updated by Karel Pičman about 1 year ago
- File copyright.diff copyright.diff added
Here is a patch covering missing copyright headers.
Updated by Marius BĂLTEANU 11 months ago
- Status changed from New to Closed
- Assignee set to Marius BĂLTEANU
- Resolution set to Fixed
Committed, thanks!
Updated by Mischa The Evil 11 months ago
- Status changed from Closed to Reopened
Thanks for fixing this. However, given our current asset serving mechanism, I'd have chosen to only add a short copyright notice to the CSS and JS assets instead.
With the current change we increase bandwidth usage more than necessary IMHO and as such we might want to (re-)consider this...
Updated by Mischa The Evil 11 months ago
Additionally, r22482 also adds a header to acts_as_tree
plugin files, which is obviously incorrect (it's in fact a vendored third-party core component, see source:/trunk/lib/plugins/acts_as_tree/README).
Updated by Marius BĂLTEANU 10 months ago
Thanks Mischa for review the changes, I have fixed now all the reported issues.
Updated by Go MAEDA 10 months ago
- Status changed from Closed to Reopened
I think we should not add Redmine's copyright header to source:trunk/public/stylesheets/tribute-5.1.3.css because the file is a part of Tribute distribution.
https://github.com/zurb/tribute/blob/master/dist/tribute.css
Updated by Marius BĂLTEANU 10 months ago
- Status changed from Reopened to Closed
Go MAEDA wrote in #note-9:
I think we should not add Redmine's copyright header to source:trunk/public/stylesheets/tribute-5.1.3.css because the file is a part of Tribute distribution.
https://github.com/zurb/tribute/blob/master/dist/tribute.css
Agree, fixed, thanks!