Feature #39529
open
Add tooltips for clarifying non-notifiable user mentions
0%
Description
Currently, when a user without permission to view a particular issue is mentioned, they do not receive a notification email. However, visually, the mention link appears identical to others, which can be misleading as there's no indication that no email was sent.
In issue Feature #39528: Change mention link color for users without access to view issues, I proposed changing the background color of mention links for such users to make it clear they are non-notifiable. However, I believe that visual change alone may not sufficiently convey the intent to users. Therefore, I suggest using tooltips to display a message clarifying the status of the mention.
Yet, since tooltips are only used for displaying title attributes right now, expanding their use might require some discussion, which is why I have created a separate ticket for this matter.
Files
Related issues
Updated by Mizuki ISHIKAWA almost 2 years ago
- File feature-39528.patch feature-39528.patch added
Updated by Mizuki ISHIKAWA almost 2 years ago
- File feature-39529.patch feature-39529.patch added
- File screenshot.png screenshot.png added
Sorry, https://www.redmine.org/attachments/31460 file was attached by mistake.
After applying the attached patch, the tooltip will appear as shown in the screenshot.
Updated by Go MAEDA over 1 year ago
- Target version set to Candidate for next major release
Updated by Mizuki ISHIKAWA over 1 year ago
- File feature-39529-v2.patch feature-39529-v2.patch added
- File screenshot 2024-01-04 16.00.10.png screenshot 2024-01-04 16.00.10.png added
- File screenshot 2024-01-04 16.00.20.png screenshot 2024-01-04 16.00.20.png added
I changed it based on the UI for when there is an invalid watcher.
Updated by Go MAEDA about 1 year ago
- File feature-39529-v3.patch feature-39529-v3.patch added
I have modified the patch with the following changes:
- Shortened long lines of code
- Fixed a missing translation error for
:notice_mention_watcher
Updated by Go MAEDA about 1 year ago
- Target version changed from Candidate for next major release to 6.0.0
Setting the target version to 6.0.0.
Updated by Go MAEDA about 1 year ago
- Related to Feature #39528: Change mention link color for users without access to view issues added
Updated by Marius BĂLTEANU about 1 year ago
Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.
Updated by Go MAEDA about 1 year ago
Marius BĂLTEANU wrote in #note-8:
Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.
Do you mean something like this?
notice_invalid_notification: "Invalid %{type}: User will not receive %{type} notifications because they do not have access to view this object."
Updated by Go MAEDA 11 months ago
Marius BĂLTEANU wrote in #note-8:
Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.
I would like to commit this patch for 6.0.0 without modifying the translation.
How about we consider unifying the translations in 6.1.0?
Unification like #note-9 may cause a capitalization issue reported in #37072.
Updated by Marius BĂLTEANU 6 months ago
- Related to Feature #13919: Mention user on issues and wiki pages using @user with autocomplete added
Updated by Marius BĂLTEANU 6 months ago
- Status changed from New to Needs feedback
I'm not sure that I fully understand the proposed change because:
1. users_for_mention checks the object visibility and we have have also a test for this case test_notified_mentions_should_not_include_users_who_cannot_view_the_object, so in theory you cannot mention a user who does not have access to that issue/object.
2. If a mentioned user in a previous note/content loses access to that issue/object, indeed, it's displayed in the same way as an user with access (#39528), but regardless the object visibility, the user won't receive any mention notification because we send notifications only for users that are mentioned in the current action (case 1).
Updated by Go MAEDA 9 days ago
Marius BĂLTEANU wrote in #note-14:
1.
users_for_mentionchecks the object visibility and we have have also a test for this casetest_notified_mentions_should_not_include_users_who_cannot_view_the_object, so in theory you cannot mention a user who does not have access to that issue/object.
The users_for_mention method is only used for the autocomplete feature when selecting users to mention. During autocomplete, users who don't have permission to view the object are not shown as candidates.
However, if you manually type a login id like `@rhill` without using autocomplete, the text is still rendered as "@Robert Hill" with a link to the user's profile, even if the user has no access. This linking feature was implemented a long time ago in #4179, well before the mention feature existed.
Currently, when typing `@rhill` manually:
If the user has access to the object:
- Display: Shows "@Robert Hill" linked to the user's profile
- Email notification: Sent (mention works)
If the user does not have access:
- Display: Still shows "@Robert Hill" linked to the user's profile
- Email notification: Not sent
So, even though the rendered text looks the same, email notifications are only sent if the mentioned user has permission. This can confuse users because it looks like they mentioned someone, but no email is delivered.
The patch aims to avoid that confusion by changing how links are rendered for users who cannot access the object.
Updated by Marius BĂLTEANU 7 days ago
- Target version changed from 6.1.0 to Candidate for next major release