Project

General

Profile

Actions

Feature #39529

open

Add tooltips for clarifying non-notifiable user mentions

Added by Mizuki ISHIKAWA about 1 year ago. Updated 10 days ago.

Status:
New
Priority:
Normal
Category:
Text formatting
Target version:
Start date:
Due date:
% Done:

0%

Estimated time:
Resolution:

Description

Currently, when a user without permission to view a particular issue is mentioned, they do not receive a notification email. However, visually, the mention link appears identical to others, which can be misleading as there's no indication that no email was sent.

In issue Feature #39528: Change mention link color for users without access to view issues, I proposed changing the background color of mention links for such users to make it clear they are non-notifiable. However, I believe that visual change alone may not sufficiently convey the intent to users. Therefore, I suggest using tooltips to display a message clarifying the status of the mention.
Yet, since tooltips are only used for displaying title attributes right now, expanding their use might require some discussion, which is why I have created a separate ticket for this matter.


Files

feature-39528.patch (1.49 KB) feature-39528.patch Mizuki ISHIKAWA, 2023-11-08 09:10
feature-39529.patch (4.09 KB) feature-39529.patch Mizuki ISHIKAWA, 2023-11-08 09:45
screenshot.png (64.3 KB) screenshot.png Mizuki ISHIKAWA, 2023-11-08 09:46
feature-39529-v2.patch (2.74 KB) feature-39529-v2.patch Mizuki ISHIKAWA, 2024-01-04 07:59
screenshot 2024-01-04 16.00.10.png (49.3 KB) screenshot 2024-01-04 16.00.10.png invalid watcher Mizuki ISHIKAWA, 2024-01-04 08:02
screenshot 2024-01-04 16.00.20.png (41.8 KB) screenshot 2024-01-04 16.00.20.png invalid mention Mizuki ISHIKAWA, 2024-01-04 08:02
feature-39529-v3.patch (2.92 KB) feature-39529-v3.patch Go MAEDA, 2024-08-22 10:40

Related issues

Related to Redmine - Feature #39528: Change mention link color for users without access to view issuesNewMarius BĂLTEANU

Actions
Actions #2

Updated by Mizuki ISHIKAWA about 1 year ago

Sorry, https://www.redmine.org/attachments/31460 file was attached by mistake.

After applying the attached patch, the tooltip will appear as shown in the screenshot.

Actions #3

Updated by Go MAEDA 11 months ago

  • Target version set to Candidate for next major release
Actions #5

Updated by Go MAEDA 3 months ago

I have modified the patch with the following changes:

  • Shortened long lines of code
  • Fixed a missing translation error for :notice_mention_watcher
Actions #6

Updated by Go MAEDA 3 months ago

  • Target version changed from Candidate for next major release to 6.0.0

Setting the target version to 6.0.0.

Actions #7

Updated by Go MAEDA 3 months ago

  • Related to Feature #39528: Change mention link color for users without access to view issues added
Actions #8

Updated by Marius BĂLTEANU 3 months ago

Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.

Actions #9

Updated by Go MAEDA 3 months ago

Marius BĂLTEANU wrote in #note-8:

Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.

Do you mean something like this?

  notice_invalid_notification: "Invalid %{type}: User will not receive %{type} notifications because they do not have access to view this object." 
Actions #10

Updated by Go MAEDA 24 days ago

Marius BĂLTEANU wrote in #note-8:

Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.

I would like to commit this patch for 6.0.0 without modifying the translation.
How about we consider unifying the translations in 6.1.0?

Unification like #note-9 may cause a capitalization issue reported in #37072.

Actions #11

Updated by Go MAEDA 19 days ago

  • Target version changed from 6.0.0 to 6.1.0

The patch should be updated to use a vector icon instead of app/assets/images/warning.png. See #23980.

Actions #12

Updated by Marius BĂLTEANU 10 days ago

  • Assignee set to Marius BĂLTEANU
Actions

Also available in: Atom PDF