Defect #37072
button_save_object should not downcase label_query
| Status: | New | Start date: | ||
|---|---|---|---|---|
| Priority: | Normal | Due date: | ||
| Assignee: | - | % Done: | 0% | |
| Category: | I18n | |||
| Target version: | - | |||
| Resolution: | Affected version: | 5.0.0 |
Description
Introduced with #34494 for translation :button_save_object the object_name uses label_query with downcase.
In German (and most likely other languages, too) the translation for label_query has to stay with an upper letter. abfrage speichern is currently generated with downcase, but it should be "Abfrage speichern"
The attached patch removes downcase from :button_save_object.
Related issues
History
#1
Updated by Alexander Meindl about 1 month ago
Found another problem with the same change for deleting issues. #31278 uses downcase for :label_issue. This cannot be used for German. In German it has to be Ticket not ticket.
Actually this problem exists with:
- :button_save_object
- :button_edit_object
- :button_delete_object
For each of these labels object_name uses downcase, which makes Redmine looks very strange in German (I'd not say unusable - but very unprofessional).
If we want to stick with :button_*_object, we need a lower case and an upper case label for all objects. E.g. label_issue and label_Issue. label_query and label_Query. But which language need the lower label and which the upper label? Because of this (unsolvable?) question, it would be better to revert :button_*_object introduction. Maybe switch to buttons with isolated label, as label_save_issue and label_save_query.
Please ignore my patch, it would only remove downcase for label_query, which does not solve all problems related to :button_*_object.
#2
Updated by Go MAEDA about 1 month ago
- Related to Patch #36905: German translation update for 5.0-stable added