Feature #39529
open
Add tooltips for clarifying non-notifiable user mentions
Added by Mizuki ISHIKAWA over 1 year ago.
Updated 20 days ago.
Description
Currently, when a user without permission to view a particular issue is mentioned, they do not receive a notification email. However, visually, the mention link appears identical to others, which can be misleading as there's no indication that no email was sent.
In issue Feature #39528: Change mention link color for users without access to view issues, I proposed changing the background color of mention links for such users to make it clear they are non-notifiable. However, I believe that visual change alone may not sufficiently convey the intent to users. Therefore, I suggest using tooltips to display a message clarifying the status of the mention.
Yet, since tooltips are only used for displaying title attributes right now, expanding their use might require some discussion, which is why I have created a separate ticket for this matter.
Files
- Target version set to Candidate for next major release
I changed it based on the UI for when there is an invalid watcher.
I have modified the patch with the following changes:
- Shortened long lines of code
- Fixed a missing translation error for
:notice_mention_watcher
- Target version changed from Candidate for next major release to 6.0.0
Setting the target version to 6.0.0.
- Related to Feature #39528: Change mention link color for users without access to view issues added
Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.
Marius BĂLTEANU wrote in #note-8:
Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.
Do you mean something like this?
notice_invalid_notification: "Invalid %{type}: User will not receive %{type} notifications because they do not have access to view this object."
Marius BĂLTEANU wrote in #note-8:
Maybe we can improve the current translation or add a new one that can be used by both mention and watcher.
I would like to commit this patch for 6.0.0 without modifying the translation.
How about we consider unifying the translations in 6.1.0?
Unification like #note-9 may cause a capitalization issue reported in #37072.
- Target version changed from 6.0.0 to 6.1.0
The patch should be updated to use a vector icon instead of app/assets/images/warning.png. See #23980.
- Assignee set to Marius BĂLTEANU
- Related to Feature #13919: Mention user on issues and wiki pages using @user with autocomplete added
- Status changed from New to Needs feedback
I'm not sure that I fully understand the proposed change because:
1. users_for_mention checks the object visibility and we have have also a test for this case test_notified_mentions_should_not_include_users_who_cannot_view_the_object, so in theory you cannot mention a user who does not have access to that issue/object.
2. If a mentioned user in a previous note/content loses access to that issue/object, indeed, it's displayed in the same way as an user with access (#39528), but regardless the object visibility, the user won't receive any mention notification because we send notifications only for users that are mentioned in the current action (case 1).
Also available in: Atom
PDF
Updated by 
Updated by 
Updated by 