Defect #39747
closed
Diff of a javascript file in repository module is not displayed with layout
0%
Description
The issue reported in #37626 reproduces now again no current trunk because the workaround was reverted. We should properly fix that issue now.
Files
Related issues
Updated by Marius BĂLTEANU about 1 year ago
- Copied from Defect #37626: Diff of a javascript file in repository module is not displayed with layout added
Updated by Mischa The Evil about 1 year ago
FWIW: I just created a history of this issue. See the following table:
Given the recurrency of the issue I think this needs a good look for the root cause(s) of it and needs a proper, enduring solution for the observed behaviors (within the moving boundaries of the Rails framework over time).
Updated by Marius BĂLTEANU about 1 year ago
Thanks Mischa, very useful!
I've already found the root cause, but I need to add and make more tests just to be sure that we have covered the known cases.
Updated by Marius BĂLTEANU about 1 year ago
- Related to Feature #36320: Migrate to Rails 7.2 added
Updated by Marius BĂLTEANU 12 months ago
- File 39747.diff 39747.diff added
The attached patch fixes the problem from my tests.
Updated by Marius BĂLTEANU 12 months ago
- Status changed from New to Resolved
- Resolution set to Fixed
Updated by Marius BĂLTEANU 12 months ago
I'm not sure why I was not able to reproduce the issue using a functional test, so I covered this using a system test. The reported problem should be fixed now un trunk, please let me know if you find any issue.
Updated by Mischa The Evil 12 months ago
Marius BALTEANU wrote in #note-10:
I'm not sure why I was not able to reproduce the issue using a functional test [...]
I'm not sure if it's related nor which functional test you mean, but I'm not sure at all whether any subversion repository fixture data from source:/trunk/test/fixtures/repositories/subversion_repository.dump.gz is actually used at all on Redmine CI runs given that the log entries of green builds are outputting:
svn: E155036: Please see the 'svn upgrade' command
svn: E155036: The working copy at '/var/lib/jenkins/workspace/trunk/DATABASE_ADAPTER/mysql/RUBY_VER/ruby-3.2' is too old (format 8) to work with client version '1.9.3 (r1718519)' (expects format 31). You need to upgrade the working copy first.
Updated by Marius BĂLTEANU 12 months ago
- Status changed from Resolved to Closed
Mischa The Evil wrote in #note-11:
Marius BALTEANU wrote in #note-10:
I'm not sure why I was not able to reproduce the issue using a functional test [...]
I'm not sure if it's related nor which functional test you mean, but I'm not sure at all whether any subversion repository fixture data from source:/trunk/test/fixtures/repositories/subversion_repository.dump.gz is actually used at all on Redmine CI runs given that the log entries of green builds are outputting:
[...]
I referred to my local environment where I tried to add a test to repositories_subversion_controller_test.rb (source:trunk/test/functional/repositories_subversion_controller_test.rb), but the problem didn't reproduce. Anyway, I think the system test is good enough.