Defect #41714: Replace search and magnifier icons with SVG icon - Redmine

Actions

Copy link

Defect #41714

closed

Replace search and magnifier icons with SVG icon

Added by Bernhard Rohloff about 1 month ago. Updated 12 days ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Target version:

6.0.2

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

There's also the checkmark showing the current project. It's different from the normal checkmark already so I think it's not that big of a deal.

Files

Download all files

clipboard-202411081112-ztkcf.png (15.1 KB) clipboard-202411081112-ztkcf.png		Bernhard Rohloff, 2024-11-08 11:13
0001-Replaces-legacy-magnifier-icon-with-SVG-icon-in-proj.patch (4.83 KB) 0001-Replaces-legacy-magnifier-icon-with-SVG-icon-in-proj.patch		Marius BĂLTEANU, 2024-11-18 23:20
0002-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-edit.patch (2.23 KB) 0002-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-edit.patch		Takenori TAKAKI, 2024-11-19 07:41
clipboard-202411191542-x07gk.png (5.82 KB) clipboard-202411191542-x07gk.png		Takenori TAKAKI, 2024-11-19 07:42
clipboard-202411191542-otfrh.png (4.73 KB) clipboard-202411191542-otfrh.png		Takenori TAKAKI, 2024-11-19 07:42
0003-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-relation.patch (1.95 KB) 0003-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-relation.patch		Takenori TAKAKI, 2024-12-06 04:35

Related issues

Actions

Copy link

Updated by Bernhard Rohloff about 1 month ago

Related to Feature #23980: Replace icon images with Tabler SVG icons added

Actions

Copy link

Updated by Marius BĂLTEANU about 1 month ago

Target version set to 6.0.1

Actions

Copy link

Updated by Marius BĂLTEANU about 1 month ago

Target version changed from 6.0.1 to 6.0.2

Actions

Copy link

Updated by Marius BĂLTEANU about 1 month ago

File 0001-Replaces-legacy-magnifier-icon-with-SVG-icon-in-proj.patch 0001-Replaces-legacy-magnifier-icon-with-SVG-icon-in-proj.patch added
Assignee set to Marius BĂLTEANU

I've attached a patch that replaces the legacy search magnifier in project jump and also in the search file on mobile view.

Actions

Copy link

Updated by Takenori TAKAKI about 1 month ago

File 0002-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-edit.patch 0002-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-edit.patch added
File clipboard-202411191542-x07gk.png clipboard-202411191542-x07gk.png added
File clipboard-202411191542-otfrh.png clipboard-202411191542-otfrh.png added

I've confirmed that the quick-jump menu icon has been updated to an SVG using the patch attached in #note-4.
Additionally, I noticed that the legacy search magnifier icon still appears in the parent_issue field on the Issue edit screen, so I created an additional patch to update it to an SVG as well.

→→

I've attached the additional patch here.

Actions

Copy link

Updated by Takenori TAKAKI 16 days ago

File 0003-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-relation.patch 0003-Replaces-legacy-magnifier-icon-with-SVG-icon-in-issue-relation.patch added

As reported in Issue #41877, the Add 'Related Issue' icon also appears to be an old icon.

I suggest an additional patch to be added to #note-5.

Actions

Copy link

Updated by Mischa The Evil 16 days ago

Takenori TAKAKI: This issue (use of legacy search magnifier icon) seems to be affecting several more places within the UI as well:

user/group search in 'Add watchers dialog'
user/group search in 'New Member dialog'
issue search in 'Add related issue to changeset form'

1 and 2 can be seen in the screenshots you have posted in #41853#note-1 and 3 is based on the actual code itself (source:/trunk/app/views/repositories/_related_issues.html.erb@23352#L35).
Most likely there are more throughout the whole system..

Actions

Copy link

Updated by Marius BĂLTEANU 13 days ago

Subject changed from The search icon in the quick-jump menu still shows the old icon. to Replace search and magnifier icons with SVG icon
Status changed from New to Resolved
Resolution set to Fixed

For now I've changed only from CSS the background image for autocomplete fields to the new SVG icon. The proper implementation requires to many changes.

Actions

Copy link