Defect #41853: Group icons in watchers and membership modals are using a mix of legacy and SVG icons - Redmine

Actions

Copy link

Defect #41853

closed

Group icons in watchers and membership modals are using a mix of legacy and SVG icons

Added by pasquale [:dedalus] 3 months ago. Updated 2 months ago.

Status:

Closed

Priority:

Normal

Assignee:

Marius BĂLTEANU

Category:

Target version:

6.0.2

Start date:

Due date:

% Done:

Estimated time:

Resolution:

Fixed

Affected version:

Description

Affected version 6.0.1

Files

Download all files

clipboard-202411241047-o2mcq.png (44.5 KB) clipboard-202411241047-o2mcq.png	issue-in-action	pasquale [:dedalus], 2024-11-24 10:47
clipboard-202411291050-yowm4.png (38.2 KB) clipboard-202411291050-yowm4.png		Takenori TAKAKI, 2024-11-29 02:50
clipboard-202411291050-lamm7.png (45.7 KB) clipboard-202411291050-lamm7.png		Takenori TAKAKI, 2024-11-29 02:50
clipboard-202411291051-u5zml.png (55.1 KB) clipboard-202411291051-u5zml.png		Takenori TAKAKI, 2024-11-29 02:51
clipboard-202411291051-grkzt.png (50.8 KB) clipboard-202411291051-grkzt.png		Takenori TAKAKI, 2024-11-29 02:52
fix-41853.patch (6.88 KB) fix-41853.patch		Takenori TAKAKI, 2024-11-29 02:52
0001-Escape-labels-in-principals_check_box_tag.patch (1.8 KB) 0001-Escape-labels-in-principals_check_box_tag.patch		Katsuya HIDAKA, 2024-11-29 19:26
0002-Fix-functional-tests-broken-by-r23328.patch (3.26 KB) 0002-Fix-functional-tests-broken-by-r23328.patch		Katsuya HIDAKA, 2024-11-29 19:26

Related issues

Actions

Copy link

Updated by Takenori TAKAKI 3 months ago

File clipboard-202411291050-yowm4.png clipboard-202411291050-yowm4.png added
File clipboard-202411291050-lamm7.png clipboard-202411291050-lamm7.png added
File clipboard-202411291051-u5zml.png clipboard-202411291051-u5zml.png added
File clipboard-202411291051-grkzt.png clipboard-202411291051-grkzt.png added
File fix-41853.patch fix-41853.patch added

I made a patch to fix the problem reported in this issue.
Additionally, this patch fixes the problem where old group icons are displayed, as shown in the attached screenshots.

Add watchers (dialog)
before

after

New Member (dialog)
before

after

Actions

Copy link

Updated by Go MAEDA 3 months ago

Status changed from New to Confirmed
Target version set to 6.0.2

Actions

Copy link

Updated by Katsuya HIDAKA 3 months ago

I reviewed the patch and tested the affected features with avatars enabled and disabled on the latest master. Everything looks good, and I didn’t notice any issues.

Actions

Copy link

Updated by Marius BĂLTEANU 3 months ago

Status changed from Confirmed to Resolved
Assignee set to Marius BĂLTEANU
Resolution set to Fixed

Committed, thanks!

Actions

Copy link

Updated by Katsuya HIDAKA 3 months ago

I have found the following issues in the current implementation:

The principals_check_box_tag labels (user and group names) are not escaped.
Some functional tests fail.

I attach minimal patches to address these issue.

I have confirmed that all tests pass.
https://github.com/hidakatsuya/redmine/actions/runs/12088933388

Actions

Copy link

Updated by Marius BĂLTEANU 2 months ago

I've committed a slightly fix, thanks Takenori TAKAKI and Katsuya HIDAKA for you help.

Actions

Copy link

Updated by Marius BĂLTEANU 2 months ago

Subject changed from Group icons in Watchers box have both the old and the new icon style to Group icons in watchers and in membership modals are not using only the SVG icon

Actions

Copy link

Updated by Marius BĂLTEANU 2 months ago

Related to Feature #23980: Replace icon images with Tabler SVG icons added

Actions

Copy link

Updated by Marius BĂLTEANU 2 months ago

Subject changed from Group icons in watchers and in membership modals are not using only the SVG icon to Group icons in watchers and membership modals are using a mix of legacy and SVG icons

Actions

Copy link

#10