Actions
Defect #41853
closed
Group icons in watchers and membership modals are using a mix of legacy and SVG icons
Added by pasquale [:dedalus] about 2 months ago. Updated about 1 month ago.
Start date:
Due date:
% Done:
0%
Estimated time:
Resolution:
Fixed
Affected version:
Description
Affected version 6.0.1
Files
| clipboard-202411241047-o2mcq.png (44.5 KB) clipboard-202411241047-o2mcq.png | issue-in-action | pasquale [:dedalus], 2024-11-24 10:47 | |
| clipboard-202411291050-yowm4.png (38.2 KB) clipboard-202411291050-yowm4.png | Takenori TAKAKI, 2024-11-29 02:50 | ||
| clipboard-202411291050-lamm7.png (45.7 KB) clipboard-202411291050-lamm7.png | Takenori TAKAKI, 2024-11-29 02:50 | ||
| clipboard-202411291051-u5zml.png (55.1 KB) clipboard-202411291051-u5zml.png | Takenori TAKAKI, 2024-11-29 02:51 | ||
| clipboard-202411291051-grkzt.png (50.8 KB) clipboard-202411291051-grkzt.png | Takenori TAKAKI, 2024-11-29 02:52 | ||
| fix-41853.patch (6.88 KB) fix-41853.patch | Takenori TAKAKI, 2024-11-29 02:52 | ||
| 0001-Escape-labels-in-principals_check_box_tag.patch (1.8 KB) 0001-Escape-labels-in-principals_check_box_tag.patch | Katsuya HIDAKA, 2024-11-29 19:26 | ||
| 0002-Fix-functional-tests-broken-by-r23328.patch (3.26 KB) 0002-Fix-functional-tests-broken-by-r23328.patch | Katsuya HIDAKA, 2024-11-29 19:26 |
Related issues
Updated by Takenori TAKAKI about 2 months ago
- File clipboard-202411291050-yowm4.png clipboard-202411291050-yowm4.png added
- File clipboard-202411291050-lamm7.png clipboard-202411291050-lamm7.png added
- File clipboard-202411291051-u5zml.png clipboard-202411291051-u5zml.png added
- File clipboard-202411291051-grkzt.png clipboard-202411291051-grkzt.png added
- File fix-41853.patch fix-41853.patch added
I made a patch to fix the problem reported in this issue.
Additionally, this patch fixes the problem where old group icons are displayed, as shown in the attached screenshots.
- Add watchers (dialog)
before
after
- New Member (dialog)
before
after
Updated by Go MAEDA about 2 months ago
- Status changed from New to Confirmed
- Target version set to 6.0.2
Updated by Katsuya HIDAKA about 2 months ago
I reviewed the patch and tested the affected features with avatars enabled and disabled on the latest master. Everything looks good, and I didn’t notice any issues.
Updated by Marius BĂLTEANU about 2 months ago
- Status changed from Confirmed to Resolved
- Assignee set to Marius BĂLTEANU
- Resolution set to Fixed
Committed, thanks!
Updated by Katsuya HIDAKA about 2 months ago
- File 0001-Escape-labels-in-principals_check_box_tag.patch 0001-Escape-labels-in-principals_check_box_tag.patch added
- File 0002-Fix-functional-tests-broken-by-r23328.patch 0002-Fix-functional-tests-broken-by-r23328.patch added
I have found the following issues in the current implementation:
- The
principals_check_box_taglabels (user and group names) are not escaped. - Some functional tests fail.
I attach minimal patches to address these issue.
I have confirmed that all tests pass.
https://github.com/hidakatsuya/redmine/actions/runs/12088933388
Updated by Marius BĂLTEANU about 1 month ago
I've committed a slightly fix, thanks Takenori TAKAKI and Katsuya HIDAKA for you help.
Updated by Marius BĂLTEANU about 1 month ago
- Subject changed from Group icons in Watchers box have both the old and the new icon style to Group icons in watchers and in membership modals are not using only the SVG icon
Updated by Marius BĂLTEANU about 1 month ago
- Related to Feature #23980: Replace icon images with Tabler SVG icons added
Updated by Marius BĂLTEANU about 1 month ago
- Subject changed from Group icons in watchers and in membership modals are not using only the SVG icon to Group icons in watchers and membership modals are using a mix of legacy and SVG icons
Updated by Marius BĂLTEANU about 1 month ago
- Status changed from Resolved to Closed
Updated by Marius BĂLTEANU about 1 month ago
- Has duplicate Defect #41870: Add Watchers windows still show old icon for group-member added
Actions