Redmine

+1

+1

+1
After applying the patch, it looks really good!
The thumbs-up icon is very useful because it allows users to widely express positive reactions, such as agreement, appreciation, or confirmation, without having to leave a comment.
I would really love to have this feature available.

Thank you for this proposal!

I do have some random remarks. Sorry for the brevity.

• We may need to check user visibility in the list of users who reacted to an object and only include users visible to User.current. As anyone can react, this may expose non-visible users otherwise. For that, it may be possible to introduce Reaction.visible scope or some other way to filter users.
• I'm not a fan of returning final user names in Redmine::Reaction::Reactable@reaction_user_names. I think we should return actual User objects here rather than names (and thus rename the method). The consumer should then format the user appropriately on the view/helper or e.g. the API. This also applies to Reaction.users_map_for_reactables
• In the ReactionsController, we should first check require_login, followed by check_enabled to avoid leaking the setting value to anonymous users.
• The ReactionsController probably needs to check the request format and handle non-js requests. See #39894 for a similar issue.
• In the reaction_text_enabling_reactions translation, we probably don't want to spell out the list ob objects one can react to so that this list does not become outdated or incomplete if we or plugins later extend the list. This should be more generic.
• The reactions should also be included in the API responses for issues, messages, ..., possibly behind an include flag

Some suggested feature work:

• Add a column and a filter for the IssueQuery to filter issues which the current user (or some other user?) has reacted to. This can be similar to the watcher column / filter. * A sortable column containing the number of reactions may be helpful. * For larger projects, a column/filter with some definition of of "recent" reactions might also help.
• Maybe add a set of permissions to control who can react and who can see reactions. These permissions probably need to be per object type (i.e. separate permissions for issues and forum posts). At least a "can react" permission would be helpful.
• A useful (later) extension may be to add negative reactions (or something like a set of possible emoji reactions, some of which may be positive or negative). While this may still need additional refinements, the design should probably allow this as a future extension.
• A user may (optionally?) want to be notified when someone reacts to one of their posts.

One additional issue:

It must not be possible to react to objects in closed projects. This may require specific checks as the view permissions are still granted here, while changes must not be possible anymore.

Edit: This and similar issues may be solved by introducing new "View reactions" (read-only) and "React" (write) permissions, similar to the various watcher permissions. If desired, we could add a migration which sensibly grants these permissions to existing roles, e.g. mirroring the watcher permissions of the respective role.